[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH] mesa: do depth/stencil format conversion in glGetTexImage
From:       Eric Anholt <eric () anholt ! net>
Date:       2014-02-28 7:55:48
Message-ID: 871tynvfgb.fsf () eliezer ! anholt ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Brian Paul <brianp@vmware.com> writes:

> glGetTexImage(GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8) was just
> using memcpy() instead of _mesa_unpack_uint_24_8_depth_stencil_row()
> to convert texels from the hardware format to the GL format.
>
> Fixes issue reported by David Meng at Intel.  The new piglit
> ext_packed_depth_stencil-getteximage test checks for this bug.
>
> Also, add some format/type assertions.  We don't yet handle the
> GL_FLOAT_32_UNSIGNED_INT_24_8_REV type.  That should be fixed in
> a follow-on patch.

Reviewed-by: Eric Anholt <eric@anholt.net>

[Attachment #5 (application/pgp-signature)]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[prev in list] [next in list] [prev in thread] [next in thread]