[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH 04/25] i965: Add helper functions to calculate the slice pitch of an array or
From:       Paul Berry <stereotype441 () gmail ! com>
Date:       2013-12-30 22:43:04
Message-ID: CA+yLL654FB_tSztWu9eHceMngHzGmOvo3KENxM8P8X_FcWaVKQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 2 December 2013 11:39, Francisco Jerez <currojerez@riseup.net> wrote:

> ---
>  src/mesa/drivers/dri/i965/brw_tex_layout.c    | 51
> +++++++++++++++++++++------
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++++++
>  2 files changed, 50 insertions(+), 11 deletions(-)
>

Since "horizontal slice pitch" and "vertical slice pitch" are not defined
in the bspec, these funtions should have documentation explaining what they
mean.

Correct me if I'm wrong, but I think what you mean by "horizontal slice
pitch" is:

- For a 3D texture, the horizontal spacing between slices at a given
miplevel.
- For any other texture, not used.

And by "vertical slice pitch"

- For a 3D texture, the vertical spacing between each row of slices.
- For any other texture, the vertical spacing between array slices.

With additional comments added, this patch is:

Reviewed-by: Paul Berry <stereotype441@gmail.com>

[Attachment #5 (text/html)]

<div dir="ltr">On 2 December 2013 11:39, Francisco Jerez <span dir="ltr">&lt;<a \
href="mailto:currojerez@riseup.net" \
target="_blank">currojerez@riseup.net</a>&gt;</span> wrote:<br><div \
class="gmail_extra"><div class="gmail_quote"> <blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>  \
src/mesa/drivers/dri/i965/brw_tex_layout.c    | 51 +++++++++++++++++++++------<br>  \
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++++++<br>  2 files changed, 50 \
insertions(+), 11 deletions(-)<br></blockquote><div><br></div><div>Since \
&quot;horizontal slice pitch&quot; and &quot;vertical slice pitch&quot; are not \
defined in the bspec, these funtions should have documentation explaining what they \
mean.<br> <br></div><div>Correct me if I&#39;m wrong, but I think what you mean by \
&quot;horizontal slice pitch&quot; is:<br><br></div><div>- For a 3D texture, the \
                horizontal spacing between slices at a given miplevel.<br></div><div>
- For any other texture, not used.<br><br></div><div>And by &quot;vertical slice \
pitch&quot;<br><br></div><div>- For a 3D texture, the vertical spacing between each \
row of slices.<br></div><div>- For any other texture, the vertical spacing between \
array slices.<br> <br></div><div>With additional comments added, this patch \
is:<br><br>Reviewed-by: Paul Berry &lt;<a \
href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>&gt;<br></div></div></div></div>




_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[prev in list] [next in list] [prev in thread] [next in thread]