[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH RFC 3/3] glsl: Rework builtin_variables.cpp to reduce code duplication.
From:       Paul Berry <stereotype441 () gmail ! com>
Date:       2013-07-12 14:03:15
Message-ID: CA+yLL66=5hx=Xe8yQaj87+QhXMs=7C4tvu84584Qp7uP=HLcgg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 11 July 2013 12:06, Matt Turner <mattst88@gmail.com> wrote:

> On Mon, Jul 8, 2013 at 10:40 AM, Paul Berry <stereotype441@gmail.com>
> wrote:
> > +   const glsl_type *typ(const char *name)
>
> This must not be a typo, since it's consistent.
>

Heh, "type" is a reserved word in so many languages that I guess I assumed
it was reserved in C++ without even checking.  Turns out it isn't.

I'm doing a minor re-spin of this patch to address Ian's comments; I'll
rename it to "type" in v2.


>
> The series is Reviewed-by: Matt Turner <mattst88@gmail.com>
>
> with the caveat that the third patch is hard to review and I could
> easily have missed something, since it's nearly a total rewrite. But
> there's no question that the final result is better. Thanks for doing
> this clean up.
>

[Attachment #5 (text/html)]

<div dir="ltr">On 11 July 2013 12:06, Matt Turner <span dir="ltr">&lt;<a \
href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>&gt;</span> \
wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div class="im">On Mon, Jul 8, 2013 at 10:40 AM, Paul Berry \
&lt;<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>&gt; \
wrote:<br> &gt; +   const glsl_type *typ(const char *name)<br>
<br>
</div>This must not be a typo, since it&#39;s \
consistent.<br></blockquote><div><br></div><div>Heh, &quot;type&quot; is a reserved \
word in so many languages that I guess I assumed it was reserved in C++ without even \
checking.  Turns out it isn&#39;t.<br> <br></div><div>I&#39;m doing a minor re-spin \
of this patch to address Ian&#39;s comments; I&#39;ll rename it to &quot;type&quot; \
in v2.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
The series is Reviewed-by: Matt Turner &lt;<a \
href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>&gt;<br> <br>
with the caveat that the third patch is hard to review and I could<br>
easily have missed something, since it&#39;s nearly a total rewrite. But<br>
there&#39;s no question that the final result is better. Thanks for doing<br>
this clean up.<br>
</blockquote></div><br></div></div>



_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[prev in list] [next in list] [prev in thread] [next in thread]