[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH RFC 3/3] glsl: Rework builtin_variables.cpp to reduce code duplication.
From:       Matt Turner <mattst88 () gmail ! com>
Date:       2013-07-11 19:06:14
Message-ID: CAEdQ38HmjS7PC1+9pdCrvsKFqip5Ox3HagAiHa7yBqUJfqtSjA () mail ! gmail ! com
[Download RAW message or body]

On Mon, Jul 8, 2013 at 10:40 AM, Paul Berry <stereotype441@gmail.com> wrote:
> +   const glsl_type *typ(const char *name)

This must not be a typo, since it's consistent.

The series is Reviewed-by: Matt Turner <mattst88@gmail.com>

with the caveat that the third patch is hard to review and I could
easily have missed something, since it's nearly a total rewrite. But
there's no question that the final result is better. Thanks for doing
this clean up.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[prev in list] [next in list] [prev in thread] [next in thread]