[prev in list] [next in list] [prev in thread] [next in thread]
List: mesa3d-dev
Subject: Re: [Mesa-dev] [PATCH] st/mesa: set the MaxVarying GLSL constant
From: José Fonseca <jfonseca () vmware ! com>
Date: 2010-08-30 10:31:38
Message-ID: 1283164298.13577.167.camel () jfonseca-laptop ! eng ! vmware ! com
[Download RAW message or body]
It makes sense now. I think you should replace the comment in the code
with the paragraph you just wrote in your reply and then push it.
Jose
On Sun, 2010-08-29 at 07:55 -0700, Marek Ol¨ák wrote:
> PIPE_CAP_MAX_FS_INPUTS specifies the number of COLORn + GENERICn
> inputs and is set in MaxNativeAttribs. It's always 2 colors + N
> generic attributes. The GLSL compiler never uses COLORn for varyings,
> so I subtract the 2 colors to get the maximum number of varyings
> (generic attributes) supported by a driver.
>
> Marek
>
> On Sun, Aug 29, 2010 at 12:06 PM, Jose Fonseca <jfonseca@vmware.com>
> wrote:
> Marek,
>
> Could you elaborate why 2 color attributes are being
> subtracted?
>
> Jose
> ________________________________________
> From: mesa-dev-bounces
> +jfonseca=vmware.com@lists.freedesktop.org [mesa-dev-bounces
> +jfonseca=vmware.com@lists.freedesktop.org] On Behalf Of Marek
> Ol¨ák [maraeo@gmail.com]
> Sent: Saturday, August 28, 2010 18:08
> To: mesa-dev@lists.freedesktop.org; Brian Paul
> Subject: Re: [Mesa-dev] [PATCH] st/mesa: set the MaxVarying
> GLSL constant
>
> May I push this? It makes glsl-max-varyings pass with r300g.
>
> Marek
>
>
>
> On Wed, Aug 25, 2010 at 5:27 AM, Marek Ol¨ák
> <maraeo@gmail.com<mailto:maraeo@gmail.com>> wrote:
> ---
> src/mesa/state_tracker/st_extensions.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_extensions.c
> b/src/mesa/state_tracker/st_extensions.c
> index 90e7867..dacba2c 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -161,6 +161,9 @@ void st_init_limits(struct st_context *st)
> pc->MaxNativeTemps = screen->get_param(screen,
> PIPE_CAP_MAX_VS_TEMPS);
> pc->MaxNativeAddressRegs = screen->get_param(screen,
> PIPE_CAP_MAX_VS_ADDRS);
> pc->MaxNativeParameters = screen->get_param(screen,
> PIPE_CAP_MAX_VS_CONSTS);
> +
> + /* Subtract 2 color attributes. */
> + c->MaxVarying = screen->get_param(screen,
> PIPE_CAP_MAX_FS_INPUTS) - 2;
> }
>
>
> --
> 1.7.0.4
>
>
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic