[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH 0/2] r600g: literals fixes
From:       Dave Airlie <airlied () gmail ! com>
Date:       2010-08-29 23:42:30
Message-ID: AANLkTik6heJcBSP7mmfupnyzWig3xtJTvMK7bjcJG5EE () mail ! gmail ! com
[Download RAW message or body]

On Sun, Aug 29, 2010 at 7:19 PM, Bas Nieuwenhuizen
<bas@basnieuwenhuizen.nl> wrote:
> I made two patches to fix problems with literals in the r600g assembler.
> 
> The first patch  inserts some r600_bc_add_literal() calls in tgsi_pow(), to ensure \
> that space accounting is done and that the correct values are set. This fixes a \
> segfault and a lockup on my computer when using a shader which uses this \
> instruction. 
> The second patch creates an array of literals and uses the index of the source \
> register to use the right literal, instead of always using the last declared \
> literal. Using realloc on each
> declaration probably is not the fastest way, but optimising it would require extra \
> accounting variables. This patch fixes about 20 glsl1 tests from glean on my \
> computer.

Thanks, indeed I get about 25 more piglits with these, pushed to master.

Dave.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[prev in list] [next in list] [prev in thread] [next in thread]