[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa3d-dev] [PATCH 0/4] Fix compilation errors when features
From:       Brian Paul <brianp () vmware ! com>
Date:       2009-10-29 13:55:03
Message-ID: 4AE99EB7.9000801 () vmware ! com
[Download RAW message or body]

Chia-I Wu wrote:
> Hi,
> 
> This patch series fixes compilation errors/warnings when features are
> disabled.  The errors mainly come from the missing symbols when texture
> format features like FEATURE_texture_{fxt1,s3tc,sRGB} are disabled.
> 
> The first patch makes _mesa_get_texstore_func never return NULL.  This
> is analogous with the what _mesa_get_texel_store_func does.
> 
> The following two patches fix compilation errors when
> FEATURE_texture_{fxt1,s3tc} are disabled.  The fetch/store functions are
> #define'd to be NULL when the respective features are disabled.  This
> approach is more clear than having a bunch of #ifdef or no-op static
> inline functions.  It is noted in the sources.  If this turns out to be
> a problem, it can always be changed to use static inline functions.
> 
> The last patch fixes compilation errors and warnings when some of
> features are disabled.  They are all simple fixes.

Committed.  Thanks.

-Brian


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
[prev in list] [next in list] [prev in thread] [next in thread]