[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa3d-dev] [PATCH] i965: Don't upload VB state when the VP
From:       Brian Paul <brianp () vmware ! com>
Date:       2009-02-26 15:29:05
Message-ID: 49A6B541.9000902 () vmware ! com
[Download RAW message or body]

Eric Anholt wrote:
> This showed up in bug #19911: When all VBs were disabled (because we were
> getting a DrawArrays with no arrays enabled, which was a bug), the VP
> got flagged as having no InputsRead.  We would proceed to emit a VB state
> packet with -1 length, and the parser got angry with us.  This doesn't fix
> the problem, as presumably the program is still trying to read this data.
> ---
>  src/mesa/drivers/dri/i965/brw_draw_upload.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> index 02998d5..cce3eba 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> @@ -469,6 +469,9 @@ static void brw_emit_vertices(struct brw_context *brw)
>  
>     brw_emit_query_begin(brw);
>  
> +   if (nr_enabled == 0)
> +      return;
> +
>     /* Now emit VB and VEP state packets.
>      *
>      * This still defines a hardware VB for each input, even if they

Looks good.

-Brian


------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
[prev in list] [next in list] [prev in thread] [next in thread]