[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mercurial-devel
Subject:    [PATCH] dispatch: properly import custom debugger
From:       Jordi_Gutiérrez_Hermoso <jordigh () octave ! org>
Date:       2023-10-03 19:51:55
Message-ID: 1ace547f92f232363f54.1696362715 () localhost
[Download RAW message or body]

# HG changeset patch
# User Jordi Gutiérrez Hermoso <jordigh@octave.org>
# Date 1696362635 14400
#      Tue Oct 03 15:50:35 2023 -0400
# Node ID 1ace547f92f232363f54a6759f3005fc6cb21157
# Parent  752c5a5b73c687588ad0f52a7d9d3e0242709a06
dispatch: properly import custom debugger

The __import__ command takes strings, not bytestrings.

I'm probably the only person who ever used this feature, but I'd much
rather debug hg with pudb than with pdb.

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -413,7 +413,7 @@ def _runcatch(req):
                     # debugging has been requested
                     with demandimport.deactivated():
                         try:
-                            debugmod = __import__(debugger)
+                            debugmod = __import__(debugger.decode('utf8'))
                         except ImportError:
                             pass  # Leave debugmod = pdb
 
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@lists.mercurial-scm.org
https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel

[prev in list] [next in list] [prev in thread] [next in thread]