[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mercurial-devel
Subject:    Re: [PATCH 2 of 2 V4] revset: raise ValueError when calling min or max on empty smartset
From:       David Soria Parra <davidsp () fb ! com>
Date:       2014-03-31 20:59:00
Message-ID: 86ha6ersob.fsf () experimentalworks ! net
[Download RAW message or body]

pierre-yves.david@ens-lyon.org writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1396051213 25200
> #      Fri Mar 28 17:00:13 2014 -0700
> # Node ID df92bd33c9002bdfcc3d5faace9ea2860d612324
> # Parent  7fc172e2b564a07bfb3ea386d9805967846c2a02
> revset: raise ValueError when calling min or max on empty smartset
>
> min([]) raise a ValueError, we do the same thing in smartset.min() and
> smartset.max() for the sake of consistency.
>
> The min/amax test are greatly improved in the process to prevent this familly
> of regression
>

Queued for default. Thank you. 
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@selenic.com
http://selenic.com/mailman/listinfo/mercurial-devel
[prev in list] [next in list] [prev in thread] [next in thread]