[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mercurial-devel
Subject:    Re: [PATCH] parsers: it should check the other interesting before decreasing ninteresting (issue3984
From:       Siddharth Agarwal <sid0 () fb ! com>
Date:       2013-07-25 20:41:47
Message-ID: 51F18D8B.1050606 () fb ! com
[Download RAW message or body]

On 07/25/2013 01:10 PM, Siddharth Agarwal wrote:
> This patch LGTM, though a better summary and perhaps a test would be 
> nice. With this patch, the invariant that ninteresting is the number 
> of non-zero elements in the interesting array is preserved.

Unfortunately, there's another bug in the C code with the calculation of 
the final list. I'll send an updated patchset once I figure out how to 
test this.
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@selenic.com
http://selenic.com/mailman/listinfo/mercurial-devel
[prev in list] [next in list] [prev in thread] [next in thread]