[prev in list] [next in list] [prev in thread] [next in thread]
List: mercurial-devel
Subject: Re: [PATCH 04 of 10 V2] branchmap: takes filtered revision in account for cache calculation
From: Pierre-Yves David <pierre-yves.david () ens-lyon ! org>
Date: 2012-12-31 23:46:37
Message-ID: 877F3AC9-B875-4D7F-ADCB-75BB0C9EFB4E () ens-lyon ! org
[Download RAW message or body]
On 1 janv. 2013, at 00:41, Augie Fackler wrote:
> =
> On Dec 28, 2012, at 12:44 PM, Dave S <snidely.too@gmail.com> wrote:
> =
>> On Thu, Dec 27, 2012 at 4:55 PM, Pierre-Yves David
>> <pierre-yves.david@ens-lyon.org> wrote:
>>> =
>>> On 26 d=E9c. 2012, at 23:25, Dave S wrote:
>> =
>>>> "build a cache [...] and then return the hash of the cache to use when=
..."
>>>> =
>>>> My current thinking, such as it is, is that being explicit about the
>>>> relationship of the hash to the cache is valuable.
>>> =
>>> You got me totally confused here :-(
>>> =
>>> Whats wrong? what do you suggest as an alternative ?
>> =
>> That was my alternative, but I'm satisfied with your taking Kevin's
>> suggestion.
>> =
>> There is still a small concern about "distinct", as I previously
>> mentioned. Do you mean "distinguish" (verb) or "distinct signature"
>> (noun) ?
> =
> I'm going to stop reviewing this series here, since my MUA is totally fai=
ling to thread this and I can't find the conversation with Kevin. Pierre-Yv=
es, can you resend patches 4:tip of this series when you're ready for re-re=
view?
V2 is the resend ready for re-review. Dave S feedback have been resolved as=
far I understand it.
Thanks for looking at it. This series if on the critical path for filtering
-- =
Pierre-Yves
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@selenic.com
http://selenic.com/mailman/listinfo/mercurial-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic