[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mercurial
Subject:    Re: How to start contributing code?
From:       Sean Farley <sean.michael.farley () gmail ! com>
Date:       2015-02-06 23:08:41
Message-ID: m2oap6ljt2.fsf () gmail ! com
[Download RAW message or body]

One of the reasons that you shouldn't drop the mailing list is so others
could try to help you when I get busy.

prafful minajigi writes:

> Hi...with respect to BUG 3718, I feel the line 363 in templater.py is
> partly responsible for the extra trailing spaces...
>
>
>    1. def join(context, mapping, args):
>    2.     if not (1 <= len(args) <= 2):
>    3.         # i18n: "join" is a keyword
>    4.         raise error.ParseError(_("join expects one or two arguments"))
>    5.     joinset = args[0][0](context, mapping, args[0][1])
>    6.     if callable(joinset):
>    7.         jf = joinset.joinfmt
>    8.         joinset = [jf(x) for x in joinset()]
>    9.     joiner = " "
>    10.     if len(args) > 1:
>    11.         joiner = stringify(args[1][0](context, mapping, args[1][1]))
>
> I feel this function is responsible for the Join operation. In the above
> code line 9 is causing the extra spaces to be generated ..

What? I'm certain that you have misread the bug report which is actually
suggesting using the 'join' template function to *add* a space between
iterated items.
_______________________________________________
Mercurial mailing list
Mercurial@selenic.com
http://selenic.com/mailman/listinfo/mercurial

[prev in list] [next in list] [prev in thread] [next in thread]