[prev in list] [next in list] [prev in thread] [next in thread]
List: mercurial
Subject: Re: Mercurial hook to set policy on tag names.
From: Idan Kamara <idankk86 () gmail ! com>
Date: 2011-07-20 12:23:47
Message-ID: CAMz0A7=DDqL3hPcofk=f67O29bWDd9QHabPiBTAnF0s57Qu3pA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Jul 19, 2011 at 4:01 PM, Oleksandr Gavenko <gavenkoa@gmail.com>
wrote:
>
> I write (in-process) hook to prevent add BAD tag name locally (which
> successfully work):
>
> .hg/hgrc:
>
> pretag.badtagname = python:.hg/hgcheck.py:localbadtag
>
> .hg/hgcheck.py:
>
> goodtag_re = r'(ver-\d+\.\d+\.\d+|tip)$'
> def localbadtag(ui, repo, hooktype, node, **kwargs):
> assert(hooktype == 'pretag')
> re_ = re.compile(goodtag_re)
> if not re_.match(tag):
> ui.warn('Invalid tag name "%s".\n' % tag)
> ui.warn('Use one of tip, ver-xx.xx.xx\n')
> return True
> return False
>
> How make this check for pretxnchangegroup hook (so prevent to adding
> bad named tags with push command on server side)?
>
> I try write this code:
>
> def pushbadtag(ui, repo, hooktype, node, **kwargs):
> assert(hooktype == 'pretxnchangegroup')
> re_ = re.compile(goodtag_re)
> for rev in xrange(repo[node].rev(), len(repo)):
> ui.warn('rev: %d\n' % rev)
> for tag in repo[rev].tags():
> ui.warn('tag: ' + tag + '\n')
> if not re_.match(tag):
> ui.warn('Invalid tag name "%s" for rev: "%s".\n' % (tag,
rev))
> ui.warn('Use one of tip, ver-xx.xx.xx\n')
> return True
> return False
>
> but when I push to repo with upper pretxnchangegroup hook enabled:
>
> $ hg tag gg
> $ hg push -f -r tip
> pushing to /cygdrive/d/home/tmp/hg/good
> searching for changes
> adding changesets
> adding manifests
> adding file changes
> added 1 changesets with 1 changes to 1 files (+1 heads)
> rev: 35
> tag: tip
>
> you can see that rev.tags() do not return gg tag! So it can not filter
The problem is the actual tag is (probably) not in the pushed csets.
If your server contains rev 0, and rev 1 is the result of `hg tag foo` and
is local,
that is rev 1 is tagging rev 0, then pushing rev 1 won't show 'foo' on any
of the incoming csets, because it already has the tagged cset, 0.
I'm not sure there's anything that can be done here on the server side,
short of inspecting the incoming csets, looking for .hgtags.
And this can get tricky, because if you have some rev is adding a bad tag,
then another
one is removing it, you wouldn't want to reject that.
Perhaps a saner approach would be to look at the incoming csets
that are also heads, and do the parsing of .hgtags on those.
[Attachment #5 (text/html)]
<div dir="ltr">On Tue, Jul 19, 2011 at 4:01 PM, Oleksandr Gavenko <<a \
href="mailto:gavenkoa@gmail.com">gavenkoa@gmail.com</a>> wrote:<br>><br>> I \
write (in-process) hook to prevent add BAD tag name locally (which<br> > \
successfully work):<br>><br>> .hg/hgrc:<br>><br>> pretag.badtagname = \
python:.hg/hgcheck.py:localbadtag<br>><br>> .hg/hgcheck.py:<br>><br>> \
goodtag_re = r'(ver-\d+\.\d+\.\d+|tip)$'<br> > def localbadtag(ui, repo, \
hooktype, node, **kwargs):<br>> assert(hooktype == 'pretag')<br>> \
re_ = re.compile(goodtag_re)<br>> if not re_.match(tag):<br>> \
ui.warn('Invalid tag name "%s".\n' % tag)<br> > \
ui.warn('Use one of tip, ver-xx.xx.xx\n')<br>> return True<br>> \
return False<br>><br>> How make this check for pretxnchangegroup hook (so \
prevent to adding<br>> bad named tags with push command on server side)?<br> \
><br>> I try write this code:<br>><br>> def pushbadtag(ui, repo, \
hooktype, node, **kwargs):<br>> assert(hooktype == \
'pretxnchangegroup')<br>> re_ = re.compile(goodtag_re)<br>> for \
rev in xrange(repo[node].rev(), len(repo)):<br> > ui.warn('rev: \
%d\n' % rev)<br>> for tag in repo[rev].tags():<br>> \
ui.warn('tag: ' + tag + '\n')<br>> if not \
re_.match(tag):<br>> ui.warn('Invalid tag name "%s" \
for rev: "%s".\n' % (tag, rev))<br> > \
ui.warn('Use one of tip, ver-xx.xx.xx\n')<br>> return \
True<br>> return False<br>><br>> but when I push to repo with upper \
pretxnchangegroup hook enabled:<br>><br> > $ hg tag gg<br>> $ hg push -f \
-r tip<br>> pushing to /cygdrive/d/home/tmp/hg/good<br>> searching for \
changes<br>> adding changesets<br>> adding manifests<br>> adding file \
changes<br>> added 1 changesets with 1 changes to 1 files (+1 heads)<br> > rev: \
35<br>> tag: tip<br>><br>> you can see that rev.tags() do not return gg tag! \
So it can not filter<br><div><br></div><div>The problem is the actual tag is \
(probably) not in the pushed csets.</div><div><br> </div><div>If your server contains \
rev 0, and rev 1 is the result of `hg tag foo` and is local,</div><div>that is rev 1 \
is tagging rev 0, then pushing rev 1 won't show 'foo' on any</div><div>of \
the incoming csets, because it already has the tagged cset, 0.</div> \
<div><br></div><div>I'm not sure there's anything that can be done here on \
the server side,</div><div>short of inspecting the incoming csets, looking for \
.hgtags.</div><div><br></div><div>And this can get tricky, because if you have some \
rev is adding a bad tag, then another</div> <div>one is removing it, you wouldn't \
want to reject that. </div><div><br></div><div>Perhaps a saner approach would be to \
look at the incoming csets</div><div>that are also heads, and do the parsing of \
.hgtags on those.</div> </div>
_______________________________________________
Mercurial mailing list
Mercurial@selenic.com
http://selenic.com/mailman/listinfo/mercurial
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic