[prev in list] [next in list] [prev in thread] [next in thread] 

List:       maven-dev
Subject:    =?utf-8?q?=5BGitHub=5D_=5Bmaven-invoker=5D_michael-o_commented_on_a_change_i?= =?utf-8?q?n_pull_requ
From:       GitBox <git () apache ! org>
Date:       2022-02-28 19:36:05
Message-ID: 164607696529.29368.16891768769649810767.asfpy () gitbox ! apache ! org
[Download RAW message or body]


michael-o commented on a change in pull request #43:
URL: https://github.com/apache/maven-invoker/pull/43#discussion_r816192410



##########
File path: src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
##########
@@ -104,6 +104,8 @@ public Commandline build( InvocationRequest request )
 
         setThreads( request, cli );
 
+        setArgsLine( request, cli );

Review comment:
       Wouldn't setArgs be better? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]