[prev in list] [next in list] [prev in thread] [next in thread] 

List:       maven-dev
Subject:    [GitHub] [maven] gnodet commented on a change in pull request #262: Improve speed in collection merg
From:       GitBox <git () apache ! org>
Date:       2019-06-30 21:56:18
Message-ID: 156193177896.6150.15284610996773417207.gitbox () gitbox ! apache ! org
[Download RAW message or body]

gnodet commented on a change in pull request #262: Improve speed in collection merging
URL: https://github.com/apache/maven/pull/262#discussion_r298851063
 
 

 ##########
 File path: maven-model/src/main/java/org/apache/maven/model/merge/ModelMerger.java
 ##########
 @@ -3018,4 +2618,298 @@ protected Object getExclusionKey( Exclusion exclusion )
         return exclusion;
     }
 
+    interface KeyComputer<T>
 
 Review comment:
   Maybe protected would be better, as they could be reused in derived classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services
[prev in list] [next in list] [prev in thread] [next in thread]