[prev in list] [next in list] [prev in thread] [next in thread] 

List:       maven-dev
Subject:    [GitHub] [maven] michael-o commented on a change in pull request #259: [MNG-6693] Various speed impr
From:       GitBox <git () apache ! org>
Date:       2019-06-28 21:53:02
Message-ID: 156175878253.2200.3326661507822975948.gitbox () gitbox ! apache ! org
[Download RAW message or body]

michael-o commented on a change in pull request #259: [MNG-6693] Various speed improvements
URL: https://github.com/apache/maven/pull/259#discussion_r298758907
 
 

 ##########
 File path: maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java
 ##########
 @@ -92,13 +92,22 @@ public static String key( Artifact artifact )
 
     public static String key( String groupId, String artifactId, String version )
     {
-        Validate.notBlank( groupId, "groupId can neither be null, empty nor blank" );
-        Validate.notBlank( artifactId, "artifactId can neither be null, empty nor blank" );
-        Validate.notBlank( version, "version can neither be null, empty nor blank" );
+        notBlank( groupId, "groupId can neither be null, empty nor blank" );
+        notBlank( artifactId, "artifactId can neither be null, empty nor blank" );
+        notBlank( version, "version can neither be null, empty nor blank" );
 
         return groupId + ":" + artifactId + ":" + version;
     }
 
+    private static void notBlank( String str, String message )
+    {
+        int c = str != null ? str.charAt( 0 ) : 0;
 
 Review comment:
   Isn't this something which should be in Commons slang rather than here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services
[prev in list] [next in list] [prev in thread] [next in thread]