[prev in list] [next in list] [prev in thread] [next in thread] 

List:       maven-dev
Subject:    [GitHub] rturner-edjuster opened a new pull request #9: [MCHECKSTYLE-365] Correct counts in Rules se
From:       GitBox <git () apache ! org>
Date:       2018-12-31 23:47:11
Message-ID: 154630003167.27247.721017973253707639.gitbox () gitbox ! apache ! org
[Download RAW message or body]

rturner-edjuster opened a new pull request #9: [MCHECKSTYLE-365] Correct counts in \
                Rules section
URL: https://github.com/apache/maven-checkstyle-plugin/pull/9
 
 
   When the site report is generated, in the Rules section, the plug-in
   groups together the violation counts for rules that have the same name
   and message, but that have different severity levels – specifically
   where one of the rules doesn't specify a severity level and uses the
   default (error). This results in both rules being listed with different
   properties and severity levels, but with the same violation count (which
   is incorrect).
   
   This change allows the rule matching to fall through to the most
   specific match rather than short-circuiting the match on success. This
   corrects the case where two rules of the same name have the same message
   but different severities and allows the match to proceed to check
   further conditions, such as the severity.
   
   In addition, this change also ensures that the severity is retrieved in
   the same way (by providing a default of "error" when missing) as the
   logic that displays the rule rows in the Rules section.
   
   Both of these changes are required to properly correct the issue.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA \
                issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed 
          for the change (usually before you start working on it).  Trivial changes \
                like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, \
without   pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and \
                body.
    - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in \
                ApproximateQuantiles`,
          where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best \
                practice
          is to use the JIRA issue title in the pull request title and in the first \
line of the   commit message.
    - [ ] Write a pull request description that is detailed enough to understand what \
                the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough \
check will   be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean \
verify`).  
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License \
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure  please ask on \
the developers list.  
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January \
2004](http://www.apache.org/licenses/LICENSE-2.0)  you have to acknowledge this by \
using the following check-box.  
    - [ ] I hereby declare this contribution to be licenced under the [Apache License \
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)  
    - [ ] In any other case, please file an [Apache Individual Contributor License \
Agreement](https://www.apache.org/licenses/icla.pdf).  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services


[prev in list] [next in list] [prev in thread] [next in thread]