[prev in list] [next in list] [prev in thread] [next in thread] 

List:       maven-dev
Subject:    svn commit: r1054101 -
From:       dennisl () apache ! org
Date:       2010-12-31 11:57:27
Message-ID: 20101231115727.46EA623888FD () eris ! apache ! org
[Download RAW message or body]

Author: dennisl
Date: Fri Dec 31 11:57:26 2010
New Revision: 1054101

URL: http://svn.apache.org/viewvc?rev=1054101&view=rev
Log:
o Refactoring: use more generic names for fields, methods and parameters.

Modified:
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java


Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java
                
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/ja \
va/org/apache/maven/plugin/jira/JiraMojo.java?rev=1054101&r1=1054100&r2=1054101&view=diff
 ==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java \
                (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraMojo.java \
Fri Dec 31 11:57:26 2010 @@ -236,15 +236,15 @@ public class JiraMojo
     public void executeReport( Locale locale )
         throws MavenReportException
     {
-        JiraDownloader jiraDownloader = new JiraDownloader();
+        JiraDownloader issueDownloader = new JiraDownloader();
 
-        setJiraDownloaderParameters( jiraDownloader );
+        configureIssueDownloader( issueDownloader );
 
         JiraReportGenerator report;
 
         try
         {
-            jiraDownloader.doExecute();
+            issueDownloader.doExecute();
 
             if ( jiraXmlPath.isFile() )
             {
@@ -270,7 +270,7 @@ public class JiraMojo
         }
         catch ( MavenReportException mre )
         {
-            // Rethrow this error from JiraReportGenerator( String, String )
+            // Rethrow this error from JiraReportGenerator( String )
             // so that the build fails
             throw mre;
         }
@@ -300,40 +300,40 @@ public class JiraMojo
         return ResourceBundle.getBundle( "jira-report", locale, \
this.getClass().getClassLoader() );  }
 
-    private void setJiraDownloaderParameters( JiraDownloader jira )
+    private void configureIssueDownloader( JiraDownloader issueDownloader )
     {
-        jira.setLog( getLog() );
+        issueDownloader.setLog( getLog() );
 
-        jira.setMavenProject( project );
+        issueDownloader.setMavenProject( project );
 
-        jira.setOutput( jiraXmlPath );
+        issueDownloader.setOutput( jiraXmlPath );
 
-        jira.setNbEntries( maxEntries );
+        issueDownloader.setNbEntries( maxEntries );
 
-        jira.setComponent( component );
+        issueDownloader.setComponent( component );
 
-        jira.setFixVersionIds( fixVersionIds );
+        issueDownloader.setFixVersionIds( fixVersionIds );
 
-        jira.setStatusIds( statusIds );
+        issueDownloader.setStatusIds( statusIds );
 
-        jira.setResolutionIds( resolutionIds );
+        issueDownloader.setResolutionIds( resolutionIds );
 
-        jira.setPriorityIds( priorityIds );
+        issueDownloader.setPriorityIds( priorityIds );
 
-        jira.setSortColumnNames( sortColumnNames );
+        issueDownloader.setSortColumnNames( sortColumnNames );
 
-        jira.setFilter( filter );
+        issueDownloader.setFilter( filter );
 
-        jira.setJiraUser( jiraUser );
+        issueDownloader.setJiraUser( jiraUser );
 
-        jira.setJiraPassword( jiraPassword );
+        issueDownloader.setJiraPassword( jiraPassword );
 
-        jira.setTypeIds( typeIds );
+        issueDownloader.setTypeIds( typeIds );
 
-        jira.setWebUser( webUser );
+        issueDownloader.setWebUser( webUser );
 
-        jira.setWebPassword( webPassword );
+        issueDownloader.setWebPassword( webPassword );
 
-        jira.setSettings( settings );
+        issueDownloader.setSettings( settings );
     }
 }


[prev in list] [next in list] [prev in thread] [next in thread]