[prev in list] [next in list] [prev in thread] [next in thread]
List: maven-dev
Subject: Re: Fix for ARCHETYPE-202
From: Hervé_BOUTEMY <herve.boutemy () free ! fr>
Date: 2010-04-28 23:38:58
Message-ID: 201004290138.58058.herve.boutemy () free ! fr
[Download RAW message or body]
I'll have a look at it in a few days
thank you for this patch
Regards,
Hervé
Le mercredi 28 avril 2010, Marco Rico-Gomez a écrit :
> Hi all,
>
> I've submitted a minor patch for
> http://jira.codehaus.org/browse/ARCHETYPE-202, which prevents users to run
> mvn archetype:generate -DarchetypeCatalog=http://example.com if they are
> behind a http proxy.
>
> I'd like to ask if someone could review it.
>
> The "download logic" is implemented three times in the class and I had to
> modify all of them. It might be better to encapsulate this functionality
> in a private function to avoid code duplication.
>
> Thanks in advance!
>
> - Marco
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic