[prev in list] [next in list] [prev in thread] [next in thread] 

List:       markus-dev
Subject:    [MarkUsProject/Markus] 7f105f: FIX issue 996.
From:       GitHub <noreply () github ! com>
Date:       2013-01-20 17:08:07
Message-ID: 50fc247772570_675c1323aec497c9 () sh3 ! rs ! github ! com ! mail
[Download RAW message or body]



----==_mimepart_50fc247762369_675c1323aec49539
Date: Sun, 20 Jan 2013 09:08:07 -0800
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <50fc247766ab3_675c1323aec496b3@sh3.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/MarkUsProject/Markus
  Commit: 7f105f7c0fd867ef56e3b68e5f64e4e11ff10cbf
      https://github.com/MarkUsProject/Markus/commit/7f105f7c0fd867ef56e3b68e5f64e4e11ff10cbf
  Author: Ian Smith <umsmit32@gmail.com>
  Date:   2013-01-19 (Sat, 19 Jan 2013)

  Changed paths:
    M app/controllers/submissions_controller.rb
    M app/helpers/submissions_helper.rb

  Log Message:
  -----------
  FIX issue 996.
Ruby 1.9.3 no longer had .id method for the Object class. Changed calls for
repository files and directories (which inherited it from id) to use
object_id instead because it is still available in 1.9.3


  Commit: 85cd500931a76ae0ec4bc921309f89db18fc177f
      https://github.com/MarkUsProject/Markus/commit/85cd500931a76ae0ec4bc921309f89db18fc177f
  Author: Benjamin Vialle <github@vialle.io>
  Date:   2013-01-20 (Sun, 20 Jan 2013)

  Changed paths:
    M app/controllers/submissions_controller.rb
    M app/helpers/submissions_helper.rb

  Log Message:
  -----------
  Merge pull request #976 from umsmit32/issue-966

Closes #966 Files added on submission page are not displayed.

When you add a file as a student on the submission page, the file doesn't show up in \
the list. On other pages it says you have uploaded a file but you can't see it.

This issue only occurs in ruby version 1.9.3 and not 1.8.7.


Compare: https://github.com/MarkUsProject/Markus/compare/43105ad2f05d...85cd500931a7

----==_mimepart_50fc247762369_675c1323aec49539--


[prev in list] [next in list] [prev in thread] [next in thread]