[prev in list] [next in list] [prev in thread] [next in thread]
List: markus-dev
Subject: Re: Stack level too deep?
From: "Evan Browning" <evan.browning () utoronto ! ca>
Date: 2010-05-05 20:51:53
Message-ID: 39DCE1B32CC74EB7900C907427C69C0C () Pearl
[Download RAW message or body]
Thanks Bryan! I hope I can keep using Windows just so that MarkUs doesn't gradually \
get completely unusable on it ;)
I wrote the fix for my original problem and MarkUs works fine now. There is a \
problem, however, with running the test cases, as Mike mentioned. The first couple \
of test cases pass, but then the rest fail because they cannot create the \
repositories that they want to create. There is an IOError because the repository \
created in the previous test case has not been deleted.
The repository is supposed to be deleted during teardown with the command \
'FileUtils.remove_dir(TEST_REPO, true)', but it is not deleted because this function, \
although it does not raise an exception, is unable to delete the directory. If I \
manually execute 'FileUtils.remove_dir(TEST_REPO)', it tells me that permission is \
denied. If I use Windows Explorer to delete the directory at this point (with \
execution still paused), it tells me I cannot delete the folder because it is in use \
by another program.
From this evidence and looking online it seems that this is caused becase the test \
code has not properly closed the file handles on the files it was using in the \
previous test case, and Windows does not allow a file to be deleted if it is open.
Any ideas how to make ruby close the files properly? I'm not sure from looking at \
the code where the files are actually opened.
Thanks
Evan
From: Bryan (Shuo) Shen
Sent: Wednesday, May 05, 2010 4:11 PM
To: Mike Conley
Cc: markus-dev
Subject: Re: Stack level too deep?
Hi Evan,
Welcome to the Markus team and thanks for the great finding!
I started with Windows but later switched to Ubuntu. This code was written last \
semester but we only tested it on Ubuntu and Mac, because nobody used Windows last \
semester, correct? So it's nice to have you tested it on Windows!
Bryan
----- Original Message -----
From: "Mike Conley" <mike.d.conley@gmail.com>
To: "markus-dev" <markus-dev@cs.toronto.edu>
Sent: Wednesday, 5 May, 2010 10:57:48 GMT -08:00 US/Canada Pacific
Subject: Re: Stack level too deep?
Tara:
I believe Joseph is referring to some problems that Bryan Shen had in
the previous semester. We ran into some pretty ugly problems when it
came to running the tests, and so he ditched it for an Ubuntu
installation.
-Mike
On Wed, May 5, 2010 at 1:28 PM, Evan Browning <evan.browning@utoronto.ca> wrote:
> As I was setting everything up yesterday I modified the Windows installation
> documentation as well, so hopefully it is up to date now. I will continue
> to update the documentation as I go :-)
>
> Evan
> From: Joseph Maté
> Sent: Wednesday, May 05, 2010 12:41 PM
> To: Evan Browning
> Cc: Severin Gehwolf ; markus-dev
> Subject: Re: Stack level too deep?
>
> It looks like I only did a reply instead of reply all. Here was the original
> message:
>
> Hey Evan,
>
> I do not believe any developers managed to get Markus running on windows. Do
> you think that you could document the steps you took in order to get Markus
> to work on the drproject wiki?
>
> Cheers,
> Joseph
>
> On May 5, 2010 9:29 AM, "Evan Browning" <evan.browning@utoronto.ca> wrote:
>
> Hi Severin,
>
> I have been working with Mike and we were able to track down the problem.
> The method File.expand_path under Windows appends the drive letter (like
> 'D:') to the path it is expanding, and MarkUs does not expect this. I am
> going to add a method expand_path to the AbstractRepository class and then
> implement it in SubversionRepository, which will correct for the problems
> with File.expand_class if it detects you are running Windows. Then I will
> see how it works.
>
> Thanks for your advice! It is true that the Subversion/Ruby bindings are
> the hardest part to get working, as I had to spend several hours yesterday
> trying to set them up properly just so MarkUs would run :P
>
> Evan
>
> --------------------------------------------------
> From: "Severin Gehwolf" <severin.gehwolf@utoronto.ca>
> Sent: Wednesday, May 05, 2010 11:45 AM
> To: "markus-dev" <markus-dev@cs.toronto.edu>
> Subject: Re: Stack level too deep?
>
> > Hi Evan,
> >
> > > Glad to have you aboard!
> >
> >
> > Welcome! Great to have you with us.
> >
> > > > I'm tryin...
--
http://www.mikeconley.ca
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content=text/html;charset=utf-8 http-equiv=Content-Type>
<STYLE type=text/css>p { margin: 0; }</STYLE>
<META name=GENERATOR content="MSHTML 8.00.7600.16535"></HEAD>
<BODY style="PADDING-LEFT: 10px; PADDING-RIGHT: 10px; PADDING-TOP: 15px"
id=MailContainerBody leftMargin=0 topMargin=0 CanvasTabStop="true"
name="Compose message area">
<DIV><FONT face=Calibri>Thanks Bryan! I hope I can keep using Windows just
so that MarkUs doesn't gradually get completely unusable on it ;)</FONT></DIV>
<DIV><FONT face=Calibri></FONT> </DIV>
<DIV><FONT face=Calibri>I wrote the fix for my original problem and MarkUs works
fine now. There is a problem, however, with running the test cases, as
Mike mentioned. The first couple of test cases pass, but then the rest
fail because they cannot create the repositories that they want to create.
There is an IOError because the repository created in the previous test case has
not been deleted. </FONT></DIV>
<DIV><FONT face=Calibri></FONT> </DIV>
<DIV><FONT face=Calibri>The repository is supposed to be deleted during teardown
with the command '<FONT size=2>FileUtils.remove_dir(TEST_REPO,</FONT><B><FONT
color=#a4357a size=2><FONT color=#a4357a size=2> true</B></FONT></FONT><FONT
size=2>)', </FONT><FONT size=3>but it is not deleted because this function,
although it does not raise an exception, is unable to delete the
directory. If I manually
execute 'FileUtils.remove_dir(TEST_REPO)', it tells me that permission is
denied. If I use Windows Explorer to delete the directory at this
point (with execution still paused), it tells me I cannot delete the
folder because it is in use by another program. </FONT></FONT></DIV>
<DIV><FONT face=Calibri></FONT> </DIV>
<DIV><FONT face=Calibri>From this evidence and looking online it seems that this
is caused becase the test code has not properly closed the file handles on the
files it was using in the previous test case, and Windows does not allow a file
to be deleted if it is open.</FONT></DIV>
<DIV><FONT face=Calibri></FONT> </DIV>
<DIV><FONT face=Calibri>Any ideas how to make ruby close the files
properly? I'm not sure from looking at the code where the files are
actually opened.</FONT></DIV>
<DIV><FONT face=Calibri></FONT> </DIV>
<DIV><FONT face=Calibri>Thanks</FONT></DIV>
<DIV><FONT face=Calibri>Evan</FONT></DIV>
<DIV><BR></DIV>
<DIV style="FONT: 10pt Tahoma">
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A
title="mailto:ssa132@sfu.ca CTRL + Click to follow link"
href="mailto:ssa132@sfu.ca">Bryan (Shuo) Shen</A> </DIV>
<DIV><B>Sent:</B> Wednesday, May 05, 2010 4:11 PM</DIV>
<DIV><B>To:</B> <A
title="mailto:mike.d.conley@gmail.com CTRL + Click to follow link"
href="mailto:mike.d.conley@gmail.com">Mike Conley</A> </DIV>
<DIV><B>Cc:</B> <A title=markus-dev@cs.toronto.edu
href="mailto:markus-dev@cs.toronto.edu">markus-dev</A> </DIV>
<DIV><B>Subject:</B> Re: Stack level too deep?</DIV></DIV></DIV>
<DIV><BR></DIV>
<DIV style="FONT-FAMILY: Times New Roman; COLOR: #000000; FONT-SIZE: 12pt">Hi
Evan,<BR><BR>Welcome to the Markus team and thanks for the great
finding!<BR><BR>I started with Windows but later switched to Ubuntu. This code
was written last semester but we only tested it on Ubuntu and Mac, because
nobody used Windows last semester, correct? So it's nice to have you tested it
on Windows! <BR><BR>Bryan<BR><BR>----- Original Message -----<BR>From: "Mike
Conley" <<A
title="mailto:mike.d.conley@gmail.com CTRL + Click to follow link"
href="mailto:mike.d.conley@gmail.com">mike.d.conley@gmail.com</A>><BR>To:
"markus-dev" <<A
href="mailto:markus-dev@cs.toronto.edu">markus-dev@cs.toronto.edu</A>><BR>Sent:
Wednesday, 5 May, 2010 10:57:48 GMT -08:00 US/Canada Pacific<BR>Subject: Re:
Stack level too deep?<BR><BR>Tara:<BR><BR>I believe Joseph is referring to some
problems that Bryan Shen had in<BR>the previous semester. We ran into some
pretty ugly problems when it<BR>came to running the tests, and so he ditched it
for an Ubuntu<BR>installation.<BR><BR>-Mike<BR><BR>On Wed, May 5, 2010 at 1:28
PM, Evan Browning <evan.browning@utoronto.ca> wrote:<BR>> As I was
setting everything up yesterday I modified the Windows installation<BR>>
documentation as well, so hopefully it is up to date now. I will
continue<BR>> to update the documentation as I go :-)<BR>><BR>>
Evan<BR>> From: Joseph Maté<BR>> Sent: Wednesday, May 05, 2010 12:41
PM<BR>> To: Evan Browning<BR>> Cc: Severin Gehwolf ; markus-dev<BR>>
Subject: Re: Stack level too deep?<BR>><BR>> It looks like I only did a
reply instead of reply all. Here was the original<BR>>
message:<BR>><BR>> Hey Evan,<BR>><BR>> I do not believe any
developers managed to get Markus running on windows. Do<BR>> you think that
you could document the steps you took in order to get Markus<BR>> to work on
the drproject wiki?<BR>><BR>> Cheers,<BR>> Joseph<BR>><BR>> On
May 5, 2010 9:29 AM, "Evan Browning" <evan.browning@utoronto.ca>
wrote:<BR>><BR>> Hi Severin,<BR>><BR>> I have been working with Mike
and we were able to track down the problem.<BR>> The method File.expand_path
under Windows appends the drive letter (like<BR>> 'D:') to the path it is
expanding, and MarkUs does not expect this. I am<BR>> going to add a
method expand_path to the AbstractRepository class and then<BR>> implement it
in SubversionRepository, which will correct for the problems<BR>> with
File.expand_class if it detects you are running Windows. Then I
will<BR>> see how it works.<BR>><BR>> Thanks for your advice! It
is true that the Subversion/Ruby bindings are<BR>> the hardest part to get
working, as I had to spend several hours yesterday<BR>> trying to set them up
properly just so MarkUs would run :P<BR>><BR>> Evan<BR>><BR>>
--------------------------------------------------<BR>> From: "Severin
Gehwolf" <severin.gehwolf@utoronto.ca><BR>> Sent: Wednesday, May 05,
2010 11:45 AM<BR>> To: "markus-dev" <markus-dev@cs.toronto.edu><BR>>
Subject: Re: Stack level too deep?<BR>><BR>>> Hi
Evan,<BR>>><BR>>>> Glad to have you
aboard!<BR>>><BR>>><BR>>> Welcome! Great to have you with
us.<BR>>><BR>>>>> I'm tryin...<BR><BR><BR><BR>--
<BR>http://www.mikeconley.ca<BR></DIV></BODY></HTML>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic