[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandrake-cooker
Subject:    Re: Fwd: [Cooker] Mandriva kmail sucks (buggy mandriva patch)
From:       Andreas Hasenack <ahasenack () terra ! com ! br>
Date:       2006-05-10 16:32:08
Message-ID: 20060510163207.GL3439 () mandriva ! com
[Download RAW message or body]

On Wed, May 10, 2006 at 06:24:05PM +0200, Per Øyvind Karlsen wrote:
> Onsdag 10 mai 2006 18:19, skrev Andreas Hasenack:
> > On Wed, May 10, 2006 at 05:33:21PM +0200, Michael Scherer wrote:
> > > Le Mercredi 10 Mai 2006 17:11, Laurent Montel a écrit :
> > > > On Wednesday 10 May 2006 16:24, Olivier Thauvin wrote:
> > > > > Still no reply, retrying...
> > > >
> > > > Read spec file before to write email
> > > > patch10 is never apply into kdepim.
> > > > Regards.
> > >
> > > Then why do you keep it in the source rpm ?
> >
> > Sometimes because that patch may be applied again in the near future, or
> > for reference for others, or for when one is not sure it should be really
> > removed.
> >
> > With the use of svn/cvs for storing .src.rpms, however, it easy to put the
> > patch back in if needed, it's like "svn cp -r 12345
> > $REPOS/SOURCES/foo.patch ."
> Yes, and that's what we already do and have done for years, so there's no real 
> need of keeping those patches..
> 
> What'll be the next? In stead of removing unused code when coding, one would 
> go to comment out code everywhere? Neat!

Of course not. One or two not-applied patches would be ok I guess, but not
dozens. And it should be the exception.

[prev in list] [next in list] [prev in thread] [next in thread]