[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandrake-cooker
Subject:    [Cooker] Re: [CHRPM] curl-7.12.3-2mdk
From:       Christiaan Welvaart <cjw () daneel ! dyndns ! org>
Date:       2005-01-31 22:38:38
Message-ID: Pine.LNX.4.58.0501312326390.21540 () zem ! cjw ! nep
[Download RAW message or body]

On Mon, 31 Jan 2005, Gwenole Beauchesne wrote:

> lundi 31 janvier 2005, à 11:01  pm, Christiaan Welvaart a écrit :
>
> > Christiaan Welvaart <cjw@daneel.dyndns.org> 7.12.3-2mdk
> >
> > - patch2 (from cvs): fix segfault on ppc
>
> Hmm, are you sure the code is semantically equivalent?

It isn't of course, the original code is broken (its behavior is probably
undefined). After reading the bug report and the code a bit it looks ok to
me. The message is printed twice in two different buffers.

> You should use va_copy instead. Now I see the code comes from upstream,
> is this something they wrote themselves actually?

http://sourceforge.net/tracker/index.php?func=detail&aid=1088962&group_id=976&atid=100976


    Christiaan


[prev in list] [next in list] [prev in thread] [next in thread]