[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandoc-tech
Subject:    Re: mdocml: Convert an assert into an explicit check.
From:       Joerg Sonnenberger <joerg () britannica ! bec ! de>
Date:       2011-12-04 0:15:50
Message-ID: 20111204001550.GA7754 () britannica ! bec ! de
[Download RAW message or body]

On Sun, Dec 04, 2011 at 12:50:05AM +0100, Ingo Schwarze wrote:
> Hi Joerg,
> 
> Joerg Sonnenberger wrote on Sat, Dec 03, 2011 at 11:47:55PM +0100:
> > On Sat, Dec 03, 2011 at 10:41:57PM +0100, Ingo Schwarze wrote:
> 
> >> That function just works fine even when the syntax tree is completely
> >> empty, only containing the ROOT node.  It is important to *NOT*
> >> return early, but to continue through the whole function and execute
> >> the man_valid_post(m) near the end - otherwise, you will end up
> >> with NULL pointers in the meta structure and provoke the crashes
> >> you observed.
> 
> > In that case at least assert that m->title etc are not NULL.
> 
> Sure, that's not going to do harm.
> 
> OK?

OK.

Joerg
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

[prev in list] [next in list] [prev in thread] [next in thread]