[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mandoc-tech
Subject:    Re: Where to put mandoc roff documentation?
From:       Ingo Schwarze <schwarze () usta ! de>
Date:       2010-11-30 21:35:50
Message-ID: 20101130213550.GB4617 () iris ! usta ! de
[Download RAW message or body]

Hi Kristaps,

Kristaps Dzonsons wrote on Mon, Nov 29, 2010 at 06:01:16PM +0100:

> I, for one, have no issues with these changes.

Good, they are now in OpenBSD, and we now install roff(7).
Thanks for your review, Jason!

> Feel free to commit them into BSD.lv.

I'd like to, but that path is blocked for now.
Kristaps, you are lacking lots of features!
Look at this:

revision 1.9
date: 2010/11/27 02:17:43;  author: schwarze;  state: Exp;  lines: +19 -2
Document .so.
This file still needs lots of love before we can consider installing it.
----------------------------
revision 1.10
date: 2010/11/27 17:46:46;  author: schwarze;  state: Exp;  lines: +240 -85
Document .de and .de1.
Extend and improve .ds documentation.
Improve .ig and .nr documentation.
Add minimal explanations for .am, .ami, .am1, and .dei.
Start improving the distinction of requests and macros.
Add myself as an author.
----------------------------
revision 1.2
date: 2010/11/28 01:00:41;  author: schwarze;  state: Exp;  lines: +17 -1
Parse and ignore the .ad, .hy, .nh, and .ne roff requests.
Ignoring these can neither cause information loss nor serious
formatting issues.  As they are frequently used by pod2man(1),
this considerably reduces ERROR noise from mandoc -Tlint
for the Perl manuals.
----------------------------
revision 1.3
date: 2010/11/29 00:12:02;  author: schwarze;  state: Exp;  lines: +30 -2
Implement the roff .ft (change font) request for man(7).
Of course, we don't want to encourage low-level physical markup,
but pod2man(1) writes such requests, so Perl manuals contain them,
and some Xenocara and lots and lots of ports manuals use them as well.
In base and Xenocara, this will reduce mandoc -Tlint ERROR noise;
in ports, it will improve rendering of many manuals.

Of course, none of this can go into bsd.lv right now,
or you badly get your code and docs out of sync.

Trying to apply just the cleanup diff blows up pathetically:

Patching file roff.7 using Plan A...
Hunk #1 failed at 15.
Hunk #2 failed at 123.
Hunk #3 failed at 169.
Hunk #4 failed at 180.
Hunk #5 failed at 203.
Hunk #6 failed at 217.
Hunk #7 failed at 238.
Hunk #8 failed at 272.
Hunk #9 succeeded at 151 with fuzz 1 (offset -155 lines).
Hunk #10 succeeded at 334 (offset -31 lines).
No such line 362 in input file, ignoring
Hunk #11 succeeded at 259 (offset -155 lines).
Hunk #12 succeeded at 399 (offset -31 lines).
Hunk #13 failed at 433.
Hunk #14 failed at 458.
Hunk #15 failed at 483.
Hunk #16 succeeded at 356 with fuzz 2 (offset -165 lines).
Hunk #17 succeeded at 506 with fuzz 2 (offset -48 lines).
11 out of 17 hunks failed--saving rejects to roff.7.rej
done

Look at the offsets, it's not even patching the right parts
of the file for those few chunks that don't conflict.

So sorry...

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

[prev in list] [next in list] [prev in thread] [next in thread]