[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mailman-cvs
Subject:    [Mailman-checkins] [Branch ~mailman-coders/mailman/2.1] Rev 1334:
From:       noreply () launchpad ! net
Date:       2011-12-13 1:35:16
Message-ID: 20111213013516.3796.91494.launchpad () ackee ! canonical ! com
[Download RAW message or body]

------------------------------------------------------------
revno: 1334
committer: Mark Sapiro <msapiro@value.net>
branch nick: 2.1
timestamp: Mon 2011-12-12 17:31:32 -0800
message:
  Fixed an erroneous seek in the Mailman.Mailbox.Mailbox.AppendMessage
  method that could cause a corrupt mailbox for files opened 'w+'.
  Bug #901957.
modified:
  Mailman/Mailbox.py
  NEWS


--
lp:mailman/2.1
https://code.launchpad.net/~mailman-coders/mailman/2.1

Your team Mailman Checkins is subscribed to branch lp:mailman/2.1.
To unsubscribe from this branch go to https://code.launchpad.net/~mailman-c=
oders/mailman/2.1/+edit-subscription

["revision-diff.txt" (revision-diff.txt)]

=== modified file 'Mailman/Mailbox.py'
--- Mailman/Mailbox.py	2009-08-01 23:15:35 +0000
+++ Mailman/Mailbox.py	2011-12-13 01:31:32 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 1998-2009 by the Free Software Foundation, Inc.
+# Copyright (C) 1998-2011 by the Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -12,7 +12,8 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
+# USA.
 
 """Extend mailbox.UnixMailbox.
 """
@@ -63,7 +64,7 @@
             if self.fp.read(1) <> '\n':
                 self.fp.write('\n')
         # Seek to the last char of the mailbox
-        self.fp.seek(1, 2)
+        self.fp.seek(0, 2)
         # Create a Generator instance to write the message to the file
         g = Generator(self.fp)
         g.flatten(msg, unixfrom=True)

=== modified file 'NEWS'
--- NEWS	2011-11-30 00:48:10 +0000
+++ NEWS	2011-12-13 01:31:32 +0000
@@ -73,6 +73,10 @@
 
   Bug Fixes and other patches
 
+    - Fixed an erroneous seek in the Mailman.Mailbox.Mailbox.AppendMessage
+      method that could cause a corrupt mailbox for files opened 'w+'.
+      Bug #901957.
+
     - A held message with a null sender caused a crash in the admindb
       interface.  This is fixed by changing the sender to <missing>.
       Bug #897103.



_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe: http://mail.python.org/mailman/options/mailman-checkins/mailman-cvs%40progressive-comp.com



[prev in list] [next in list] [prev in thread] [next in thread]