[prev in list] [next in list] [prev in thread] [next in thread] 

List:       macports-dev
Subject:    request review of PR 22645 and PR 22643 (qt5/6 Vulkan)
From:       John Hoyt <john.hoyt () gmail ! com>
Date:       2024-03-02 14:28:22
Message-ID: CAE8sghQN_LAgaE3h-gFsTAesi_z4vDzn6Cf8Q5FoXb2cTdyESg () mail ! gmail ! com
[Download RAW message or body]

Hi,

I have two PRs that have been sitting in the PR queue for a few weeks that
I would like to request a review on both.  Both add Vulkan support to qt5/6.

These two PRs are a long overdue "TODO's" marked in the qt5/6 portfiles as
Vulkan support via moltenVK wasn't quite ready 2 years ago.  I am the
guilty party marking the TODO in the original qt6 portfile.

qt5: https://github.com/macports/macports-ports/pull/22645
qt6: https://github.com/macports/macports-ports/pull/22643

Please note that the CI chains are failing due to unrelated issues in the
portfile / timeouts.  Both the qt5 and qt6 portfiles are monsters with
large amounts of subports and variants.

Thank you for the assistance.
John

[Attachment #3 (text/html)]

<div dir="ltr">Hi,<div><br></div><div>I have two PRs that have been sitting in the PR \
queue for a few weeks that I would like to request a review on both.   Both add  \
Vulkan support to qt5/6.</div><div><br></div><div>These two PRs are a long overdue \
&quot;TODO&#39;s&quot; marked in the qt5/6 portfiles as Vulkan support via moltenVK \
wasn&#39;t quite ready 2 years ago.   I am the guilty party marking the TODO in the \
original qt6 portfile.</div><div><br></div><blockquote style="margin:0 0 0 \
40px;border:none;padding:0px"><div>qt5: <a \
href="https://github.com/macports/macports-ports/pull/22645">https://github.com/macports/macports-ports/pull/22645</a></div><div>qt6: \
<a href="https://github.com/macports/macports-ports/pull/22643">https://github.com/macports/macports-ports/pull/22643</a></div><div><br></div></blockquote>Please \
note that the  CI chains are failing due  to unrelated issues in the portfile / \
timeouts.   Both the qt5 and qt6 portfiles are monsters with large amounts of \
subports and variants.<div><br>Thank you for the \
assistance.<div>John</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]