[prev in list] [next in list] [prev in thread] [next in thread] 

List:       macports-dev
Subject:    Re: [macports-ports] 01/02: at-spi2-core: update to version 2.28.0
From:       Ryan Schmidt <ryandesign () macports ! org>
Date:       2018-08-04 0:16:05
Message-ID: 8BC3045C-B71E-4DC4-A950-B92E13A1C113 () macports ! org
[Download RAW message or body]



On Aug 3, 2018, at 18:01, David B. Evans wrote:

> David B. Evans (dbevans) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/7d5300f0703c626ec2f649b38c023bbd42093236
>  
> commit 7d5300f0703c626ec2f649b38c023bbd42093236
> 
> Author: David B. Evans
> AuthorDate: Fri Aug 3 10:43:09 2018 -0700
> 
> 
> at-spi2-core: update to version 2.28.0
> 
> 
> 
> Now builds using meson. Minor reformatting.
> 
> ---
> gnome/at-spi2-core/Portfile | 44 +++++++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 19 deletions(-)
> 
> 
> diff --git a/gnome/at-spi2-core/Portfile b/gnome/at-spi2-core/Portfile
> index 186361d..f4c9607 100644
> --- a/gnome/at-spi2-core/Portfile
> +++ b/gnome/at-spi2-core/Portfile
> @@ -1,22 +1,19 @@
> # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; \
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 
> PortSystem          1.0
> -PortGroup           gobject_introspection 1.0
> +PortGroup           meson 1.0
> +PortGroup           muniversal 1.0

> depends_lib         path:lib/pkgconfig/glib-2.0.pc:glib2 \
> port:dbus \
> +                    port:gobject-introspection \
> port:xorg-libX11 \
> port:xorg-libXi \
> port:xorg-libXtst \
> port:xorg-libice \
> port:xorg-libsm
> 
> -gobject_introspection yes

> +configure.args      -Denable-introspection=yes
> +
> +# gobject-introspection uses g-ir-scanner, which uses $CC from env
> +if {[variant_isset universal]} {
> +    foreach arch ${configure.universal_archs} {
> +        lappend merger_build_env(${arch})  CC='${configure.cc} -arch ${arch}'
> +        lappend merger_destroot_env(${arch})  CC='${configure.cc} -arch ${arch}'
> +    }
> +} else {
> +    build.env-append       CC="${configure.cc} ${configure.cc_archflags}"
> +    destroot.env-append    CC="${configure.cc} ${configure.cc_archflags}"
> +}

I assume the reason for removing the gobject_introspection portgroup, and \
reimplementing its functionality in the port, is that the portgroup is designed for \
autotools and this port has switched to meson. Is there a way the portgroup could be \
enhanced to do the right thing regardless of the build system? That would be better \
than going back to copy/pasting blocks of code into each port that uses gobject \
introspection, which was the problem that the portgroup was supposed to solve.


[prev in list] [next in list] [prev in thread] [next in thread]