On Sep 26, 2012, at 11:31 AM, Ryan Schmidt wrote: >> +variant no_xmaxima description {Do not build xmaxima} { >> + depends_run-delete port:tk >> + patchfiles-append no-xmaxima.patch >> +} > > We should not use variants whose names begin with "no_" anymore. That naming scheme was necessitated by old versions of MacPorts that could not remember disabled variants. But that problem was fixed (by registry 2.0) so now we should use positively-named variants, in this case "xmaxima", and it should be on by default. > > variant xmaxima description {Build xmaxima} { > depends_run-append port:tk > } > default_variants +xmaxima > if {![variant_isset xmaxima]} { > patchfiles-append no-xmaxima.patch > } Should I reopen the ticket and add a new patch there, or create a new ticket for that? Thanks, Kuba _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev