[prev in list] [next in list] [prev in thread] [next in thread] 

List:       macports-dev
Subject:    Re: error: expected a platform name, e.g., 'macosx'
From:       Kuba Ober <kuba () mareimbrium ! org>
Date:       2012-09-24 0:47:00
Message-ID: 5D6B1E5B-8310-4543-80BB-C82C4BD2A73C () mareimbrium ! org
[Download RAW message or body]

> On Sep 22, 2012, at 6:17 AM, Ryan Schmidt wrote:
> > On Sep 22, 2012, at 05:04, Joshua Root wrote:

> > However, testing for
> > these is officially frowned upon. Whenever possible, upstream should
> > really test for specific ways in which platforms are known to differ
> > (presence of particular headers or libs, behaviour of particular
> > functions, etc.), not test for specific platforms.
> 
> Absolutely, but it's outside the scope of MacPorts maintainers' responsibilities to \
> rearchitect upstream code in such a way. If upstream code is already written with \
> preprocessor defines to detect OS X, then it's our simplest course of action to \
> replace the problematic "macosx" symbol with an already-existing Apple-provided \
> symbol that does the same thing. 
> We could also advise upstream to rewrite their code to no longer test for \
> platforms, but that's more difficult for them to do and we shouldn't let such a \
> request derail the simpler fix.

I'm not involved, but I can't help but agree. Consider this my 3c.

Cheers, Kuba Ober
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo/macports-dev


[prev in list] [next in list] [prev in thread] [next in thread]