[prev in list] [next in list] [prev in thread] [next in thread] 

List:       macports-dev
Subject:    Re: [38678] d-mode.el
From:       Joshua Root <jmr () macports ! org>
Date:       2008-07-31 7:55:28
Message-ID: 48916FF0.2090003 () macports ! org
[Download RAW message or body]

Ryan Schmidt wrote:
> 
> On Jul 28, 2008, at 12:10, jmr@macports.org wrote:
> 
>> Revision: 38678
>>           http://trac.macosforge.org/projects/macports/changeset/38678
>> Author:   jmr@macports.org
>> Date:     2008-07-28 10:10:42 -0700 (Mon, 28 Jul 2008)
>> Log Message:
>> -----------
>> New port: d-mode.el (#15792)
> 
> I suggest:
> 
>  * removing the backslash at the end of the long description
>  * using "extract.mkdir yes" instead of "file mkdir ${worksrcpath}" in 
> the extract phase
>  * using "copy" instead of "file copy"
>  * using "${distpath}" instead of 
> "${prefix}/var/macports/distfiles/${name}"

Done. Thanks for spotting those.

- Josh
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
[prev in list] [next in list] [prev in thread] [next in thread]