[prev in list] [next in list] [prev in thread] [next in thread]
List: lyx-devel
Subject: Re: [patch] - GIT - version control for LyX documents not detected
From: Peter_Kümmel <syntheticpp () gmx ! net>
Date: 2016-01-19 6:56:20
Message-ID: 8AD08869-0E91-4234-882C-8489042250A4 () gmx ! net
[Download RAW message or body]
Am 18. Januar 2016 23:25:03 MEZ, schrieb Pavel Sanda <sanda@lyx.org>:
> Stephan Witt wrote:
> > The attached patch fixes the broken detection of GIT version control.
> > It seems so that Qt is caching the file meta data and fools the test
> > of file emptiness. Perhaps this has changed with Qt5 and didn???t
> happen
> > with Qt4???
>
> Bad news, if your analysis is correct, we might encounter the same
> problem
> in other parts of the code as well. I don't have easy access to qt5 to
> test.
>
> Quick check says we use is FileEmpty also in:
> Buffer.cpp: enable = (d->preview_file_).exists() &&
> !(d->preview_file_).isFileEmpty();
> LaTeX.cpp: rerun = idxfile.exists() && idxfile.isFileEmpty();
> LaTeX.cpp: if (head.haschanged(nlofile) || (nlofile.exists() &&
> nlofile.isFileEmpty()))
>
> Pavel
I did not follow this git stuff, but I assume current implementation tries to use \
system git calls via Qt classes, am I right? I really could imagine this makes \
problems, because of Qt.
Afaik QtCreator tries the same, is any code used from there in LyX?
Had someone the idea to use libgit2 instead of the system git? Was it evaluated? I \
assume then there we have much more control over the git files.
Peter
[Attachment #3 (text/html)]
<html><head></head><body><div class="gmail_quote">Am 18. Januar 2016 23:25:03 MEZ, \
schrieb Pavel Sanda <sanda@lyx.org>:<blockquote class="gmail_quote" \
style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); \
padding-left: 1ex;"> <pre class="k9mail">Stephan Witt wrote:<br /><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; \
padding-left: 1ex;"> The attached patch fixes the broken detection of GIT version \
control.<br /> It seems so that Qt is caching the file meta data and fools the \
test<br /> of file emptiness. Perhaps this has changed with Qt5 and didn???t \
happen<br /> with Qt4???<br /></blockquote><br />Bad news, if your analysis is \
correct, we might encounter the same problem<br />in other parts of the code as well. \
I don't have easy access to qt5 to test.<br /><br />Quick check says we use is \
FileEmpty also in:<br />Buffer.cpp: enable = \
(d->preview_file_).exists() && !(d->preview_file_).isFileEmpty();<br \
/>LaTeX.cpp: rerun = idxfile.exists() && idxfile.isFileEmpty();<br \
/>LaTeX.cpp: if (head.haschanged(nlofile) || (nlofile.exists() && \
nlofile.isFileEmpty()))<br /><br />Pavel<br /></pre></blockquote></div><br \
clear="all">I did not follow this git stuff, but I assume current implementation \
tries to use system git calls via Qt classes, am I right? I really could imagine this \
makes problems, because of Qt. <br> <br>
Afaik QtCreator tries the same, is any code used from there in LyX?<br>
<br>
Had someone the idea to use libgit2 instead of the system git? Was it evaluated? I \
assume then there we have much more control over the git files.<br> <br>
Peter </body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic