[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [PATCH] Exit with error if no filename given to -e switch
From:       Scott Kostyshak <skostysh () lyx ! org>
Date:       2013-03-30 4:04:36
Message-ID: CAO7dr0jgFy+rnhpB8ZrmKo-3+LhESY+k3=54Yapuhonzcw0fww () mail ! gmail ! com
[Download RAW message or body]

On Fri, Mar 29, 2013 at 12:34 PM, Richard Heck <rgheck@lyx.org> wrote:
> On 03/29/2013 11:55 AM, Scott Kostyshak wrote:
>>
>> On Fri, Mar 29, 2013 at 11:31 AM, Scott Kostyshak <skostysh@lyx.org>
>> wrote:
>>>
>>> On Fri, Mar 29, 2013 at 8:58 AM, Jos=E9 Matos <jamatos@lyx.org> wrote:
>>>>
>>>> On Friday 29 March 2013 11:36:36 Kornel Benko wrote:
>>>>
>>>>> Should we change the description, or parsing of the command line?
>>>>>          Kornel
>>>>
>>>>
>>>>
>>>> As long as the meaning is clear I prefer to be very liberal about the
>>>> command line arguments. Unless the order really matters it really help=
s
>>>> if
>>>> the arguments parser is resilient. So, if possible, IMHO we should mak=
e
>>>> the
>>>> parser more permissive.
>>>
>>> OK, I will find a more flexible alternative. It would be nice if we
>>> had some tests for which commands should give an error which commands
>>> should not. This would allow for flexibility but at the same time
>>> increase the robustness of the code so that it is not unknowingly
>>> broken by commits like the one I reverted.
>>>
>>> Scott
>>
>> How about the attached patch?
>>
>> I have no idea if it breaks something else. I've tested with commands
>> that I know to work (e.g. lyx -help, lyx -dbg) and it seems to work
>> fine.
>
> That one looks better.

OK, it's in at d42c5fcd.

Thanks,

Scott
[prev in list] [next in list] [prev in thread] [next in thread]