[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: no GUI error when configure fails on first configure
From:       Richard Heck <rgheck () comcast ! net>
Date:       2012-05-21 14:20:33
Message-ID: 4FBA4F31.7050901 () comcast ! net
[Download RAW message or body]

On 05/21/2012 01:57 AM, Scott Kostyshak wrote:
> *From:* Richard Heck [rgheck@comcast.net]
> *Sent:* Sunday, May 20, 2012 9:53 AM
>
> >I think the GUI is accessible at this point---if use_gui is true. So 
> you might just try something like:
> >    if (use_gui)
> >        frontend::Alert(...);
> >    else
> >        LYXERR0(...);
> >at the relevant point. If not, then we need more complex return 
> values from init().
>
> The attached patch issues a GUI message if configure fails. I wasn't 
> sure about where to put the code. It is unfortunately spread out 
> because I couldn't issue a GUI message at the time of checking if 
> configure succeeded.
>
> The patch also includes two minor changes to the reconfigure code in 
> GuiApplication::reconfigure:
>
> (1) I "consted" the return value and (2) I added a line break to the 
> message.
>
OK, I see the problem.

That said, the error message is wrong. If there were no text classes, 
then we would have told the user this at the beginning of 
LyX:execCommands(). I guess the question, then, is: If initial 
configuration failed, what do we have or not have?

Richard


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    On 05/21/2012 01:57 AM, Scott Kostyshak wrote:
    <blockquote
cite="mid:055B2A349DB9C841BDBE4C28453CF09E1BE234BA@CSGMBX200W.pu.win.princeton.edu"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=ISO-8859-1">
      <div style="direction: ltr; font-family: Tahoma; color: rgb(0, 0,
        0); font-size: 10pt;"><span style="font-weight: bold;"></span><font
          size="2"><b>From:</b> Richard Heck [<a class="moz-txt-link-abbreviated" \
href="mailto:rgheck@comcast.net">rgheck@comcast.net</a>]<br>  </font>
        <div style="font-family: Times New Roman; color: rgb(0, 0, 0);
          font-size: 16px;">
          <div style="direction: ltr;" id="divRpF399535"><font
              color="#000000" face="Tahoma" size="2"><b>Sent:</b>
              Sunday, May 20, 2012 9:53 AM<br>
            </font><br>
          </div>
          <div>&gt;I think the GUI is accessible at this point---if
            use_gui is true. So you might just try something like:<br>
            &gt; &nbsp;&nbsp; if (use_gui)<br>
            &gt; &nbsp;&nbsp; &nbsp;&nbsp;&nbsp; frontend::Alert(...);<br>
            &gt; &nbsp;&nbsp; else<br>
            &gt; &nbsp;&nbsp; &nbsp;&nbsp;&nbsp; LYXERR0(...);<br>
            &gt;at the relevant point. If not, then we need more complex
            return values from init().<br>
            <br>
            The attached patch issues a GUI message if configure fails.
            I wasn't sure about where to put the code. It is
            unfortunately spread out because I couldn't issue a GUI
            message at the time of checking if configure succeeded.<br>
            <br>
            The patch also includes two minor changes to the reconfigure
            code in GuiApplication::reconfigure:<br>
            <br>
            (1) I "consted" the return value and (2) I added a line
            break to the message.<br>
            <br>
          </div>
        </div>
      </div>
    </blockquote>
    OK, I see the problem. <br>
    <br>
    That said, the error message is wrong. If there were no text
    classes, then we would have told the user this at the beginning of
    LyX:execCommands(). I guess the question, then, is: If initial
    configuration failed, what do we have or not have?<br>
    <br>
    Richard<br>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic