[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: r28977 - lyx-devel/trunk/src
From:       Abdelrazak Younes <younes () lyx ! org>
Date:       2009-03-30 15:53:25
Message-ID: 49D0EAF5.4090708 () lyx ! org
[Download RAW message or body]

Richard Heck wrote:
> younes@lyx.org wrote:
>> Author: younes
>> Date: Mon Mar 30 09:44:01 2009
>> New Revision: 28977
>> URL: http://www.lyx.org/trac/changeset/28977
>>
>> Log:
>> gcc compile fix.
>>
>> Modified:
>>    lyx-devel/trunk/src/SpellChecker.h
>>
>> Modified: lyx-devel/trunk/src/SpellChecker.h
>> ============================================================================== 
>>
>> --- lyx-devel/trunk/src/SpellChecker.h    Mon Mar 30 03:43:40 2009    
>> (r28976)
>> +++ lyx-devel/trunk/src/SpellChecker.h    Mon Mar 30 09:44:01 2009    
>> (r28977)
>> @@ -63,6 +63,9 @@
>>      virtual docstring const error() = 0;
>>  };
>>  
>> +/// Access to the singleton SpellChecker.
>> +/// Implemented in LyX.cpp
>> +SpellChecker * theSpellChecker();
>>  
>>   
> Is this going to be created when LyX starts, or when the spell checker 
> is first used?

Right now when LyX starts.

> I'd prefer the latter, if that's not too hard, or to create at startup 
> only if we know we are going to need it.

It's not hard to do it when first used but I don't really see the 
advantage. The Aspell class is quite small and we link to the Aspell 
library anyway. It's only when first used for a given language that the 
Aspell library will load the support code for the asked language.
If you really don't want to load the spellchecker there are two solutions:
1) don't link to it (--disable-aspell or something)
2) dlopen libaspell.so instead of linking to it.

2) means that our aspell support becomes a "plugin" which, in itself is 
a nice thing that I would like to do. Especially if we create plugins 
for other spellcheckers (Myspell and hunspell)...

Abdel.

[prev in list] [next in list] [prev in thread] [next in thread]