[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [patch] Fix UI GuiTabular
From:       Jürgen_Spitzmüller <juergen () spitzmueller ! org>
Date:       2008-11-17 13:06:20
Message-ID: 200811171406.21017.juergen () spitzmueller ! org
[Download RAW message or body]

Vincent van Ravesteijn wrote:
> I'm fixing the current design of the dialog. Whether the design should
> be changed is the next question ?

It should have been changed long ago. Maybe you'll find the time. The current 
design is only a burden of the past.

> PS. I removed the new policy again, because it seemed unnecessary.
>
> >> - When editing the width edit field is not finished by an enter but by
> >> tab, a mouseclick or something else, the value is not applied.
> >>    
> >
> > I would not expect it to be applied, actually.
> >  
>
> I do. Now all values are applied immediately when changed, except the
> width (if you don't press enter).

I do not have too strong opinions.

> >> - The default of valign is TOP and not MIDDLE. This is defined in
> >> various constructors in InsetTabular.cpp.
> >>    
> >
> > LaTeX-wise, TOP is the default. Also note that LaTeX tables have another
> > notion of valign than what you might expect. See
> > http://wiki.lyx.org/LyX/Tables#toc2
> >  
>
> Sorry, I wasn't clear probably. The initial value of the vertical
> alignment is now middle, until a width is entered. Then, it changes
> automatically to top. I just adjusted the initial value to top, so this
> does not longer annoy me. (This is not important any way.)

I see. This makes sense.

> > Jürgen
> >  
>
> I think I'll commit these small changes (except the new policy), is it
> also ok for branch ?

OK.

Jürgen

[prev in list] [next in list] [prev in thread] [next in thread]