[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [patch] Fix UI GuiTabular
From:       Vincent van Ravesteijn <V.F.vanRavesteijn () tudelft ! nl>
Date:       2008-11-17 11:21:13
Message-ID: 492153A9.1070607 () tudelft ! nl
[Download RAW message or body]

Vincent van Ravesteijn schreef:
>
> Solving:
> - The GuiTabular dialog has an auto-apply policy. The buttoncontroller 
> however changes the Close button into Cancel, while pressing Cancel 
> does apply the settings. Therefore I added a new ButtonPolicy: 
> AutoApplyPolicy.
> - When editing the width edit field is not finished by an enter but by 
> tab, a mouseclick or something else, the value is not applied.
> - The default of valign is TOP and not MIDDLE. This is defined in 
> various constructors in InsetTabular.cpp.
>
> OK to apply in trunk and branch ?
>
> Vincent
>
On second thought, the AutoApplyPolicy is unnecessary. I could just use 
the IgnorantPolicy without adding the close button to the buttoncontroller.

I think the rest of the patch is ok.

Vincent
[prev in list] [next in list] [prev in thread] [next in thread]