[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [Cvslog] r26583 - /lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp
From:       Jean-Marc Lasgouttes <Jean-Marc.Lasgouttes () inria ! fr>
Date:       2008-09-29 8:53:15
Message-ID: liyy71bgwp0.fsf () pegase ! inria ! fr
[Download RAW message or body]

sanda@lyx.org writes:
> Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5285 .
> --- lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp (original)
> +++ lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp Fri Sep 26 23:34:08 2008
> @@ -338,6 +338,7 @@
>  
>  	bufferview()->updateMetrics();
>  	bufferview()->buffer().changed();
> +	bufferview()->buffer().markDirty();
>  }

This is typically a consequence of code that tries to be smart: directly
access param at point when we do not have a selection, and avoid to
dispatch an lfun. 

So, when we have several paragraphs, the dirty flag is correctly set,
but when there is only one, nothing correct happens. I really do not
understand why it can be needed to separate these two cases (it
corresponds to more code, AFAIK).

I think this chage should be reverted and GuiParagraph should be changed
to work through LyXFunc.

Abdel, maybe?

JMarc
[prev in list] [next in list] [prev in thread] [next in thread]