[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-devel
Subject:    Re: [Cvslog] r23433 - /lyx-devel/trunk/src/Buffer.cpp
From:       Jean-Marc Lasgouttes <lasgouttes () lyx ! org>
Date:       2008-03-04 14:13:04
Message-ID: liywsoid1cf.fsf () pegase ! inria ! fr
[Download RAW message or body]

Abdelrazak Younes <younes@lyx.org> writes:

> Inset that are in texted are not a problem as the buffer is set in
> readInset(). The main and probably only problem is for math inset
> parsing where the buffer is not accessible (see parse1() and
> parse2()). The clean solution is to pass the Buffer there.

Or to move your loop to InsetMathHull::setBuffer (if this thing can be
called in readParToken).

>> This loop is probably very expensive.
>
> Not really, this is what we do for updateLabels() for example.

You mean what we _used_ to do... This iterating is noticeable on large
document. At least I think what we do should be documented.

JMarc
[prev in list] [next in list] [prev in thread] [next in thread]