[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-cvs
Subject:    [LyX/master] Add comment regarding fsanitize + Clang issue
From:       Scott Kostyshak <skostysh () lyx ! org>
Date:       2021-12-30 16:10:57
Message-ID: 20211230161057.C1727280234 () lyx ! lyx ! org
[Download RAW message or body]

commit 4bdb1ca4c26e275ef1e4bc592a95210f78839bc5
Author: Scott Kostyshak <skostysh@lyx.org>
Date:   Thu Dec 30 11:37:12 2021 -0500

    Add comment regarding fsanitize + Clang issue
    
    We could not figure out the root issue, or at least not to the point
    where we felt changing this code considering we could not trigger
    any bug from a user perspective.
    
    For now, we just add a comment in the code.
    
    For more information, see our ML discussion here:
    
      https://www.mail-archive.com/search?l=mid&q=20211227113249.53bf5a63%40admin1-desktop
---
 src/support/socktools.cpp |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/support/socktools.cpp b/src/support/socktools.cpp
index d4aab38..d014f45 100644
--- a/src/support/socktools.cpp
+++ b/src/support/socktools.cpp
@@ -111,6 +111,13 @@ int listen(FileName const & name, int queue)
 	// bind() gives the local address 'name' for 'fd', also creating
 	// the socket special file in the filesystem. bind() returns -1
 	// in case of error
+	//
+	// Using Clang and fsanitize suggests there is an issue here but we do
+	// not understand the code enough to change it and we are not aware of
+	// how to trigger a crash or other issue while using LyX, so we leave
+	// it as is. For ML discussion, see here:
+	//   https://www.mail-archive.com/search?l=mid&q=20211227113249.53bf5a63%40admin1-desktop
+	//
 	if ((::bind (fd, reinterpret_cast<sockaddr *>(&addr), SUN_LEN(&addr))) == -1) {
 		LYXERR0("lyx: Could not bind address '" << name.absFileName()
 		       << "' to socket descriptor: " << strerror(errno));
-- 
lyx-cvs mailing list
lyx-cvs@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-cvs
[prev in list] [next in list] [prev in thread] [next in thread]