[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-cvs
Subject:    [LyX/master] Replace coverity annotation by assertions
From:       Jean-Marc Lasgouttes <lasgouttes () lyx ! org>
Date:       2017-03-31 9:48:05
Message-ID: 20170331094806.019C0280259 () lyx ! lyx ! org
[Download RAW message or body]

commit 6b2444a7df3674be08d401d4a9381d420a0c0faa
Author: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date:   Fri Mar 31 11:47:47 2017 +0200

    Replace coverity annotation by assertions
---
 src/frontends/qt4/GuiView.cpp |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiView.cpp
index 625a424..be9425b 100644
--- a/src/frontends/qt4/GuiView.cpp
+++ b/src/frontends/qt4/GuiView.cpp
@@ -3253,10 +3253,9 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
 
 		string rev1 = cmd.getArg(0);
 		string f1, f2;
+		LATTEST(buffer)
 
 		// f1
-		// it seems safe to assume we have a buffer
-		// coverity[FORWARD_NULL]
 		if (!buffer->lyxvc().prepareFileRevision(rev1, f1))
 			break;
 
@@ -4019,9 +4018,9 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
 			break;
 
 		case LFUN_FORWARD_SEARCH: {
-		// it seems safe to assume we have a document buffer, since
-		// getStatus wants one.
-		// coverity[FORWARD_NULL]
+			// it seems safe to assume we have a document buffer, since
+			// getStatus wants one.
+			LATTEST(doc_buffer);
 			Buffer const * doc_master = doc_buffer->masterBuffer();
 			FileName const path(doc_master->temppath());
 			string const texname = doc_master->isChild(doc_buffer)

[prev in list] [next in list] [prev in thread] [next in thread]