[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lyx-cvs
Subject:    Re: [LyX/master] Add the icon-size to the toolbar menu
From:       Jürgen Spitzmüller <spitz () lyx ! org>
Date:       2016-11-23 14:32:12
Message-ID: CAE_dPV5ZUzqhX7r24f0VEZd7gNVjTuxneivKyxZZqnaQYRcV2A () mail ! gmail ! com
[Download RAW message or body]

2016-11-22 10:02 GMT+01:00 Jean-Marc Lasgouttes <lasgouttes@lyx.org>:

> commit e91572a00bd61d56b5386519b52d316a32974497
> Author: Daniel Ramöller <d.lyx@web.de>
> Date:   Sun Oct 9 09:15:20 2016 +0200
>
>     Add the icon-size to the toolbar menu
>
>     - Adds LFUNs for setting the icon size
>     - Adds icons sizes to the Toolbars menu
>     - Uses the Toolbars menu as application context menu
>     - The context menu can now be user defined in stdcontext.inc
>
>     Fixes ticket #10428.
>


This triggers a couple new warnings:

GuiView.cpp:3318:43: warning: unused parameter ‘pos' [-Wunused-parameter]
 void GuiView::toolBarPopup(const QPoint & pos)
                                           ^~~
GuiView.cpp: In member function ‘void
lyx::frontend::GuiView::dispatch(const lyx::FuncRequest&,
lyx::DispatchResult&)':
GuiView.cpp:3734:13: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
    if (size == d.smallIconSize)
        ~~~~~^~~~~~~~~~~~~~~~~~
GuiView.cpp:3736:18: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
    else if (size == d.normalIconSize)
             ~~~~~^~~~~~~~~~~~~~~~~~~
GuiView.cpp:3738:18: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
    else if (size == d.bigIconSize)
             ~~~~~^~~~~~~~~~~~~~~~
GuiView.cpp:3740:18: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
    else if (size == d.hugeIconSize)
             ~~~~~^~~~~~~~~~~~~~~~~
GuiView.cpp:3742:18: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
    else if (size == d.giantIconSize)
             ~~~~~^~~~~~~~~~~~~~~~~~

Jürgen

[Attachment #3 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2016-11-22 10:02 \
GMT+01:00 Jean-Marc Lasgouttes <span dir="ltr">&lt;<a \
href="mailto:lasgouttes@lyx.org" \
target="_blank">lasgouttes@lyx.org</a>&gt;</span>:<br><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">commit \
                e91572a00bd61d56b5386519b52d31<wbr>6a32974497<br>
Author: Daniel Ramöller &lt;<a href="mailto:d.lyx@web.de">d.lyx@web.de</a>&gt;<br>
Date:     Sun Oct 9 09:15:20 2016 +0200<br>
<br>
      Add the icon-size to the toolbar menu<br>
<br>
      - Adds LFUNs for setting the icon size<br>
      - Adds icons sizes to the Toolbars menu<br>
      - Uses the Toolbars menu as application context menu<br>
      - The context menu can now be user defined in stdcontext.inc<br>
<br>
      Fixes ticket #10428.<br></blockquote><div><br><br></div><div>This triggers a \
couple new warnings:<br><br>GuiView.cpp:3318:43: warning: unused parameter ‘pos' \
[-Wunused-parameter]<br>  void GuiView::toolBarPopup(const QPoint &amp; pos)<br>      \
^~~<br>GuiView.cpp: In member function ‘void lyx::frontend::GuiView::dispatch(const \
lyx::FuncRequest&amp;, lyx::DispatchResult&amp;)':<br>GuiView.cpp:3734:13: warning: \
comparison between signed and unsigned integer expressions [-Wsign-compare]<br>       \
if (size == d.smallIconSize)<br>               \
~~~~~^~~~~~~~~~~~~~~~~~<br>GuiView.cpp:3736:18: warning: comparison between signed \
and unsigned integer expressions [-Wsign-compare]<br>       else if (size == \
d.normalIconSize)<br>                         \
~~~~~^~~~~~~~~~~~~~~~~~~<br>GuiView.cpp:3738:18: warning: comparison between signed \
and unsigned integer expressions [-Wsign-compare]<br>       else if (size == \
d.bigIconSize)<br>                         \
~~~~~^~~~~~~~~~~~~~~~<br>GuiView.cpp:3740:18: warning: comparison between signed and \
unsigned integer expressions [-Wsign-compare]<br>       else if (size == \
d.hugeIconSize)<br>                         \
~~~~~^~~~~~~~~~~~~~~~~<br>GuiView.cpp:3742:18: warning: comparison between signed and \
unsigned integer expressions [-Wsign-compare]<br>       else if (size == \
d.giantIconSize)<br>                         \
~~~~~^~~~~~~~~~~~~~~~~~<br><br></div></div>Jürgen<br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]