[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lxc-devel
Subject:    [lxc-devel] [lxc/lxc] dc4df2: lxc/lxccontainer: specify file mode in open() call...
From:       "'Christian Brauner' via lxc-devel" <lxc-devel () lists ! linuxcontainers ! org>
Date:       2024-04-02 12:55:38
Message-ID: lxc/lxc/push/refs/heads/main/80e28c-17aaad () github ! com
[Download RAW message or body]

  Branch: refs/heads/main
  Home:   https://github.com/lxc/lxc
  Commit: dc4df233595daa1b6eaa5a18d495b0a995660f7f
      https://github.com/lxc/lxc/commit/dc4df233595daa1b6eaa5a18d495b0a995660f7f
  Author: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxc/lxccontainer: specify file mode in open() call inside mod_rdep

We must explicitly specify file mode in open(.. O_CREAT ..).

Let's set 0644, while previously it was 0666 [1] which seems too much.

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=libio/fileops.c;h=4db4a76f755b1f3b766dc47c669c09242395ec95;hb=HEAD#l216


Fixes: Coverity 1596044
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>


  Commit: 17aaada7c7ec434668399ab87d5e81a2a5d78715
      https://github.com/lxc/lxc/commit/17aaada7c7ec434668399ab87d5e81a2a5d78715
  Author: Christian Brauner <christian@brauner.io>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Merge pull request #4419 from mihalicyn/fixup_mod_rdep

lxc/lxccontainer: specify file mode in open() call inside mod_rdep


Compare: https://github.com/lxc/lxc/compare/80e28c1fe9db...17aaada7c7ec

To unsubscribe from these emails, change your notification settings at \
https://github.com/lxc/lxc/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups "lxc-devel" \
group. To unsubscribe from this group and stop receiving emails from it, send an \
email to lxc-devel+unsubscribe@lists.linuxcontainers.org. To view this discussion on \
the web visit https://groups.google.com/a/lists.linuxcontainers.org/d/msgid/lxc-devel/lxc/lxc/push/refs/heads/main/80e28c-17aaad%40github.com.



[prev in list] [next in list] [prev in thread] [next in thread]