[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lxc-devel
Subject:    [lxc-devel] [python2-lxc/master] mark some internal functions static
From:       benjaminp on Github <lxc-bot () linuxcontainers ! org>
Date:       2017-11-30 7:40:13
Message-ID: 20171130074013.6CAA51E149 () mailman01 ! srv ! dcmtl ! stgraber ! net
[Download RAW message or body]

[Attachment #2 (text/x-mailbox)]

The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/python2-lxc/pull/14

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Generally, Python extensions shouldn't be exporting any symbols except for the initialization function.

[Attachment #3 (text/plain)]

From 9f86a0b92515a02e98c267caab5ee9623cdd8088 Mon Sep 17 00:00:00 2001
From: Benjamin Peterson <benjamin@python.org>
Date: Wed, 29 Nov 2017 23:38:19 -0800
Subject: [PATCH] mark some internal functions static

---
 lxc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lxc.c b/lxc.c
index 1cc43c9..06e63e9 100644
--- a/lxc.c
+++ b/lxc.c
@@ -47,7 +47,8 @@ static int PyUnicode_FSConverter(PyObject *unicode, void *result)
 
 /* Helper functions */
 
-int lxc_wait_for_pid_status(pid_t pid)
+static int
+lxc_wait_for_pid_status(pid_t pid)
 {
     int status, ret;
 
@@ -63,7 +64,7 @@ int lxc_wait_for_pid_status(pid_t pid)
     return status;
 }
 
-char**
+static char**
 convert_tuple_to_char_pointer_array(PyObject *argv) {
     int argc;
     int i, j;
@@ -257,7 +258,8 @@ static lxc_attach_options_t *lxc_attach_parse_options(PyObject *kwds)
     return options;
 }
 
-void lxc_attach_free_options(lxc_attach_options_t *options)
+static void
+lxc_attach_free_options(lxc_attach_options_t *options)
 {
     int i;
     if (!options)

[Attachment #4 (text/plain)]

_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel


[prev in list] [next in list] [prev in thread] [next in thread]