[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lvm2-commits
Subject:    =?utf-8?q?=5Blvm2-commits=5D?= main - tests: udev-pvscan-vgchange fix wait
From:       David Teigland <teigland () sourceware ! org>
Date:       2021-11-11 22:59:23
Message-ID: 20211111225923.DA5A1385840F () sourceware ! org
[Download RAW message or body]

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=20c550ab10e50d25249ed0b0553ff8a33ed3348f
Commit:        20c550ab10e50d25249ed0b0553ff8a33ed3348f
Parent:        0e0faf30e01f78828b7e240f57217755b62650bb
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Thu Nov 11 16:04:24 2021 -0600
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Thu Nov 11 16:04:24 2021 -0600

tests: udev-pvscan-vgchange fix wait

the service now remains after completion
---
 test/shell/udev-pvscan-vgchange.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/test/shell/udev-pvscan-vgchange.sh b/test/shell/udev-pvscan-vgchange.sh
index f0d637562..fcd8e961b 100644
--- a/test/shell/udev-pvscan-vgchange.sh
+++ b/test/shell/udev-pvscan-vgchange.sh
@@ -71,15 +71,11 @@ wipe_all() {
 	done
 }
 
-# udevadm trigger runs udev rule which runs systemd-run --no-wait vgchange -aay
-# Because of --no-wait, we need to wait for the transient systemd
-# service to be gone before checking the effects of the vgchange.
-
 wait_lvm_activate() {
 	local vgw=$1
 	local wait=0
 
-	while systemctl status lvm-activate-$vgw > /dev/null && test "$wait" -le 30; do
+	while systemctl status lvm-activate-$vgw | grep "active (running)" && test "$wait" -le 30; do
 		sleep .2
 		wait=$(( wait + 1 ))
 	done
_______________________________________________
lvm2-commits mailing list -- lvm2-commits@lists.fedorahosted.org
To unsubscribe send an email to lvm2-commits-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/lvm2-commits@lists.fedorahosted.org
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[prev in list] [next in list] [prev in thread] [next in thread]