[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lvm2-commits
Subject:    =?utf-8?q?=5Blvm2-commits=5D?= master - pvscan: remove fixme comment that is fixed
From:       David Teigland <teigland () sourceware ! org>
Date:       2019-04-29 20:48:03
Message-ID: 20190429204803.E10215709F604 () mailman01 ! phx2 ! fedoraproject ! org
[Download RAW message or body]

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=6d0f09f4783061054152ae0013d7ebfad949c343
Commit:        6d0f09f4783061054152ae0013d7ebfad949c343
Parent:        c3e385c1087321986ae1bc9346f2b00f5790e75c
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Mon Apr 29 15:42:20 2019 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Mon Apr 29 15:44:57 2019 -0500

pvscan: remove fixme comment that is fixed

Remove the fixme comment describing the case that was
fixed by aa75b31db54782fb24b6b7e3c681a61b3579117c
  "pvscan: handle case of scanning PV without metadata last"
---
 tools/pvscan.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/tools/pvscan.c b/tools/pvscan.c
index 61d9cc8..d3b2b8e 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -1062,18 +1062,6 @@ int pvscan_cache_cmd(struct cmd_context *cmd, int argc, char **argv)
 		cmd->pvscan_recreate_hints = 1;
 		pvscan_recreate_hints_begin(cmd);
 
-		/*
-		 * FIXME: if _online_pvscan_all_devs scans a PV without
-		 * metadata as the final PV to complete the VG, then
-		 * that VG is not added to the complete_vgnames list.
-		 * To fix this, we could also keep an incomplete_vg list,
-		 * and each incomplete_vg entry would list the PVIDs it
-		 * still needed.  If a PV without metadata is scanned,
-		 * its PVID would be removed from the incomplete_vg entry,
-		 * and if the entry had no remaining PVs needed, the vgname
-		 * would be added to complete_vgnames.
-		 */
-
 		log_verbose("pvscan all devices for requested refresh.");
 		_online_files_remove(_pvs_online_dir);
 		_online_files_remove(_vgs_online_dir);
_______________________________________________
lvm2-commits mailing list -- lvm2-commits@lists.fedorahosted.org
To unsubscribe send an email to lvm2-commits-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/lvm2-commits@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]