[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lvm2-commits
Subject:    =?utf-8?q?=5Blvm2-commits=5D?= master - coverity: make use of defined variable
From:       Zdenek Kabelac <zkabelac () sourceware ! org>
Date:       2018-03-17 22:35:39
Message-ID: 20180317223539.4488C24B463CC () mailman01 ! phx2 ! fedoraproject ! org
[Download RAW message or body]

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=f2d0eefa770468e8cdd126ce09a251bdf804884e
Commit:        f2d0eefa770468e8cdd126ce09a251bdf804884e
Parent:        26c58027fb9df068c927abe61336ff6364fe3d0e
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Sat Mar 17 13:56:44 2018 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Sat Mar 17 23:33:58 2018 +0100

coverity: make use of defined variable

Since we declare 'r', let's use the value for something.
---
 lib/device/dev-io.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/device/dev-io.c b/lib/device/dev-io.c
index cb3a234..1d16a66 100644
--- a/lib/device/dev-io.c
+++ b/lib/device/dev-io.c
@@ -649,14 +649,10 @@ static int _aligned_io(struct device_area *where, char *write_buffer,
 	/* ... then we write */
 	devbuf->write = 1;
 	if (!(r = _io(devbuf, 0)))
-		goto_bad;
-
-	_release_devbuf(devbuf);
-	return 1;
-
+		stack;
 bad:
 	_release_devbuf(devbuf);
-	return 0;
+	return r;
 }
 
 static int _dev_get_size_file(struct device *dev, uint64_t *size)
_______________________________________________
lvm2-commits mailing list -- lvm2-commits@lists.fedorahosted.org
To unsubscribe send an email to lvm2-commits-leave@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]