[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lvm-devel
Subject:    Re: [lvm-devel] [PATCH 4/4] Move activation of background polling processes to a common function.
From:       Alasdair G Kergon <agk () redhat ! com>
Date:       2009-09-29 20:44:20
Message-ID: 20090929204420.GS5351 () agk-dp ! fab ! redhat ! com
[Download RAW message or body]

On Tue, Sep 29, 2009 at 11:22:57AM -0400, Mike Snitzer wrote:
> Move activation of background polling processes to a common function.
> Avoids code duplication and fixes an associated where vgchange would
> only restart pvmove and _not_ lvconvert (lvchange would restart
> both).
 
Applied, but I've retained the more-efficient version for pvmove for
vgchange: when you know you are looping through all the LVs in the VG
you can skip the normal (LOCKED) LVs which are being moved and trigger
from the PVMOVE ones that perform the pvmove.  As lvchange might only
be processing a single LV, you can't do that.

Alasdair

[prev in list] [next in list] [prev in thread] [next in thread]