[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lvm-devel
Subject:    [lvm-devel] [PATCH mirror 11/13] Allow multiple mirror logs in the mirror LV tree
From:       "Jun'ichi Nomura" <j-nomura () ce ! jp ! nec ! com>
Date:       2007-11-22 2:09:48
Message-ID: 4744E4EC.6010500 () ce ! jp ! nec ! com
[Download RAW message or body]

With the "10/13" patch,  mirror LV can have multiple logs in
its layers.
This patch enables the namings of "lv_mlog_<n>" and
removes a code to force corelog from lvconvert.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America


["lvm2-stacked-mirror-multi-mlogs.patch" (text/x-patch)]

Index: LVM2.work/tools/toollib.c
===================================================================
--- LVM2.work.orig/tools/toollib.c
+++ LVM2.work/tools/toollib.c
@@ -1249,14 +1249,11 @@ int generate_log_name_format(struct volu
 		return 0;
 	}
 
-	/* FIXME I think we can cope without this.  Cf. _add_lv_to_dtree()
 	if (find_lv_in_vg(vg, buffer) &&
-	    dm_snprintf(buffer, size, "%s_mlog_%%d",
-			 lv_name) < 0) {
+	    dm_snprintf(buffer, size, "%s_mlog_%%d", lv_name) < 0) {
 		stack;
 		return 0;
 	}
-	*******/
 
 	return 1;
 }
Index: LVM2.work/tools/lvconvert.c
===================================================================
--- LVM2.work.orig/tools/lvconvert.c
+++ LVM2.work/tools/lvconvert.c
@@ -464,8 +464,6 @@ static int lvconvert_mirrors(struct cmd_
 			return 1;
 		}
 	} else if (lp->mirrors > existing_mirrors) {
-		/* FIXME: can't have multiple mlogs. force corelog. */
-		corelog = 1;
 		if (!_add_mirror(cmd, lv, lp->mirrors - existing_mirrors,
 				 corelog, lp))
 			return_0;


[prev in list] [next in list] [prev in thread] [next in thread]